bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#1191: How to contribute back changes for Emacs on Solaris


From: Dan Nicolaescu
Subject: bug#1191: How to contribute back changes for Emacs on Solaris
Date: Thu, 23 Oct 2008 17:22:46 -0700 (PDT)

Ali Bahrami <ali_gnu@emvision.com> writes:

  > Dan Nicolaescu wrote:
  > > Ali Bahrami <ali_gnu@emvision.com> writes:
  > ...
  > >   >     % ./config.guess
  > >   >     i386-pc-solaris2.11
  > >   >     % CC='gcc -m64' ./config.guess
  > >   >     amd64-solaris2.11
  > >        ^^^^^^^^^^^^^^^^^^
  > > This does not look right, it needs to be a triplet, not a pair, so 
amd64-pc-solaris2.11
  > 
  > I found that interesting too, which is one reason I showed that output
  > to Ben in our other discussion. I trust that he'll flag it if its wrong.
  > However, emacs configure is happy with this, so perhaps it's really OK,

IMHO amd64-solaris2 is not a good idea.  config.guess is used by
anything that uses autoconf, there are many many scripts that depend on
having a triple.  What you had to fix in configure.in is just one such
example.

  > I'll fix whatever is needed there.
  > 
  > Isn't the idea of having a "vendor" for instruction sets rather
  > dated? I surely don't care who made my CPU, only what ISA it
  > supports and what OS is running.

Probably, but it's been around for a while, so it's ingrained in many
places... 

  > > BTW, context or unified diffs are preferred here. 
  > 
  > Understood, and I have been sending context diffs until this
  > last one. The bits that got missed made me think that perhaps
  > it was the wrong thing. Sorry, I'll go back to doing that.

The patch did not apply cleanly, I got rejects so I had to hand edit the
change.  Hence the problem, but don't worry about it, it's all good as
long as things move forward.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]