bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#789: find-function fails on advised subrs


From: Glenn Morris
Subject: bug#789: find-function fails on advised subrs
Date: Sat, 08 Nov 2008 14:37:47 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

martin rudalics wrote:

> I attached a tentative fix.  Please try it.

Hi martin, I finally tried this...

> !     (cond
> !      ((and (symbolp fun-or-var) (featurep 'advice)
> !        (ad-get-advice-info fun-or-var))
> !       (setq advised t))
> !      ((not type)
> !       (setq fun-or-var (indirect-function fun-or-var))))

This fails if I have an alias to an advised function.

> !      ;; Get the real definition.
> !      (def (if (symbolp real-function)
> !               (symbol-function real-function)
> !             function))
> !      file-name string aliases)

file-name and string seem unused.

> !     (cond
> !      (advised
> !       (message "This function is advised"))

Should this function be printing if something is advised?
Again, what about aliases to advised functions?

Otherwise, it seems to work ok.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]