Re: bug#1380: 23.0.60; file content causes CVS emacs to crash

[Ted Zlatanov]

On Fri, 21 Nov 2008 12:41:43 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> On Fri, 21 Nov 2008 11:25:07 +0900 Kenichi Handa <handa@m17n.org> wrote: 
KH> In article <87myfuhmrk.fsf@cyd.mit.edu>, Chong Yidong 
<cyd@stupidchicken.com> writes:
>>> > The file content in a file causes Emacs to crash as soon as it's
>>> > opened.  Tested with "emacs -q file".

>>> Looks like the charbuf in the coding structure is overflowing.  The
>>> following rough patch prevents this overflow and the crash, but maybe
>>> there is a deeper bug.  The comments in coding.c:6610 says "We are sure
>>> that the number of data is less than the size of coding->charbuf."  This
>>> bug comes about due to that faile assumption.

>>> Handa-san, what do you think?

KH> I found that it's a bug in detect/decode_coding_iso_2022,
KH> and just installed a fix.

TZ> Fix confirmed here.

When I tried to commit the file discussed in the original bug report to
a CVS repository, Emacs crashed with a segfault.  The file was
committed, so this happened after the cvs executable was called.  I
didn't do a thorough debugging session because this is very likely to be
a proliferation of the same bug, but if you can't duplicate it I will
produce a backtrace, etc.

Thanks
Ted