bug#1483: cleanup: replace NO_SOCKETS_IN_FILE_SYSTEM in emacsclient.c

[Eli Zaretskii]

> Date: Wed, 3 Dec 2008 14:03:45 -0800 (PST)
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Cc: 1483@emacsbugs.donarmstrong.com, jasonr@f2s.com
> 
>   > > The clear precedent is that WINDOWSNT already encompasses a bazillion
>   > > features, why would a bazillion + 1 won't make any difference?
>   > 
>   > As Eli pointed out, we should be moving towards decreasing the
>   > bazillion things conflated into #ifdef WINDOWSNT, not increasing them.
> 
> Good luck convincing anyone about that.

I don't see any need for convincing someone about that.  Making such
changes is routine maintenance that doesn't need any approval.  The
main problem is to find a volunteer for this huge job.

> There are 378 undocumented macros in admin/CPP-DEFINES, and probably
> 1000-2000 in use in src/*, increasing that number does not seem such
> a hot idea.

The sheer number of defines is not the problem.  The problem is that
some or maybe even most of them don't clearly tell what they mean.  It
is this problem that IMO we should work on, not just on removing
defines or lumping unrelated features into a single OS-dependent
define.