bug#1801: 23.0.60; (with-ns) Cancel button in Preferences should always cancel

[B. Smith-Mannschott]

This is a usability bug.

Observed Behavior
=================

 - Start Emacs
 - Choose "Preferences..." from the application menu ("Emacs").
 - (An "Emacs Preferences" Window opens)
 - Choose "Hyper" as the Modifier for Alt/Option key
 - Click OK
 - (The preference window closes)
 - Choose "Preferences..." from the application menu ("Emacs").
 - Click "Reset to Defaults"
 - (The Modifier for Alt/Option key is now "Meta")
 - Click Cancel
 - Choose "Preferences..." from the application menu ("Emacs")
 - (The Modifier for Alt/Option key is still "Meta", despite having
   clicked cancel.)

Expected Behavior
=================

I expect Cancel to always cancel the changes made in the preferences
window.  More specifically, I expect cancel to return the settings
displayed in the preferences window to the state they were in when the
window was intially opened.

Configuration
=============

- gcc --version | head -n 1
  i686-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc. build 5488)

In GNU Emacs 23.0.60.1 (i386-apple-darwin9.6.0, NS apple-appkit-949.43)
 of 2009-01-06 on Meheadable.local
Windowing system distributor `Apple', version 10.3.949
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  openwith-mode: t
  yas/minor-mode: t
  global-hl-line-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<backspace> <backspace> <backspace> <backspace> <backspace>
f o n t SPC c o n t r o l SPC C-d C-d C-d C-d C-d C-d
C-d C-d C-d C-d <backspace> <backspace> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
s e l e c t i o n SPC <escape> q C-n C-n C-b C-b C-b
C-b C-f C-n C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-a
C-k C-p C-p C-y C-o C-n C-n C-n C-k C-SPC C-n C-n C-n
C-g C-e C-x C-s C-p C-p C-p C-p C-p C-p C-p C-p C-p
C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n
C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n SPC SPC SPC
SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC SPC ; ; SPC
s o m e SPC o f SPC t h e s e SPC C-n SPC SPC SPC SPC
SPC ; ; SPC p r o p e r t i e s SPC m a y C-n SPC SPC
SPC SPC SPC SPC SPC SPC SPC SPC ; ; SPC n o t SPC b
e SPC n e c e s s a r y C-p C-p C-b C-b C-b C-b C-b
C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b
C-b C-b C-b C-a C-f C-f C-f C-f C-f C-f C-f C-f C-f
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f
C-f C-b C-b C-k C-n C-f C-f C-f C-f C-f C-f C-f C-f
C-f C-k C-n C-k C-b C-b C-b C-b C-b C-k C-x C-s <switch-frame>
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Mark saved where search started
Mark set [2 times]
Auto-saving...done
Wrote /Users/bsmith/Wiki/notes/EmacsBugNoCompletionOfFonts.txt
Mark set [2 times]
Quit
Wrote /Users/bsmith/Wiki/notes/EmacsBugNoCompletionOfFonts.txt
Auto-saving...done
Wrote /Users/bsmith/Wiki/notes/EmacsBugNoCompletionOfFonts.txt
byte-code: Beginning of buffer [8 times]
byte-code: Beginning of buffer