bug#2110: 23.0.60; vc-annotate-revision-previous-to-line fails on git

[Dan Nicolaescu]

Eric Hanchrow <eric.hanchrow@gmail.com> writes:

  > Please write in English if possible, because the Emacs maintainers
  > usually do not have translators to read other languages for them.
  > 
  > Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing 
list.
  > 
  > Please describe exactly what actions triggered the bug
  > and the precise symptoms of the bug:
  > 
  > Place the following into a file, make it executable, and run it:
  > 
  >     #!/bin/bash
  > 
  >     d=$(mktemp -d)
  >     cd $d
  >     git init
  > 
  >     for i in $(seq 4)
  >     do echo $i > i
  >         git add i
  >         git commit -m $i
  >     done
  > 
  >     cat<<EOF > bug.el
  >     (find-file "i")
  >     (message "vc-handled-backends: %s" vc-handled-backends)
  >     (call-interactively 'vc-annotate)
  >     (call-interactively 'vc-annotate-revision-previous-to-line)
  >     EOF
  > 
  >     emacs --no-site-file --batch -l bug.el
  > 
  > The output I see is
  > 
  >     Initialized empty Git repository in /tmp/tmp.OYiYC29959/.git/
  >     [master (root-commit) df7f76c] 1
  >      1 files changed, 1 insertions(+), 0 deletions(-)
  >      create mode 100644 i
  >     [master 767a453] 2
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     [master b0271d9] 3
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     [master e46c84d] 4
  >      1 files changed, 1 insertions(+), 1 deletions(-)
  >     Warning: Lisp directory `/usr/local/share/emacs/23.0.60/site-lisp'
  > does not exist.
  >     Warning: Lisp directory `/usr/local/share/emacs/site-lisp' does not 
exist.
  >     Loading vc-git...
  >     vc-handled-backends: (RCS CVS SVN SCCS Bzr Git Hg Mtn Arch)
  >     Annotating...
  >     Redisplaying annotation...
  >     Redisplaying annotation...done (Spanned from 0.3 to 0.3 days old)
  >     Mark set
  >     Annotating... done
  >     Annotating...
  >     Running git blame undefined i...FAILED (status 128)
  > 
  > The bug is the failure in the last line.

This is because vc-git-previous-revision calls vc-git-symbolic-commit
which runs:
git name-rev --name-only --tags COMMIT
which returns "undefined"
running just:
git name-rev --name-only COMMIT
seems to be better in this particular case.  No idea if that's TRTD
though...