[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in
From: |
Stefan Monnier |
Subject: |
bug#2439: 23.0.60; [patch] `Mark set' clobbers useful message in |
Date: |
Wed, 25 Feb 2009 14:53:56 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.0.90 (gnu/linux) |
>> Thanks for your patch, but please try to avoid hardcoding "1" as above.
>> Just use (point-min) instead.
> What is the point, when having a narrowed buffer would be an error?
Because 1 is sometimes an error, whereas (point-min) isn't.
> because `goto-line' uses `(save-restriction (widen) ...)'. So, if
> anything, is not that the patch should use `point-min', but that it
> should use
> (save-restriction
> (widen)
> (goto-char 1)
> (forward-line orig))
No, it should be
(save-restriction
(widen)
(goto-char (point-min))
(forward-line orig))
> though I don't think narrowing the ibuffer buffer and then sorting is
> a common enough operation to worry about it. Same for bs-down, where
> I implemented the same fix.
Agreed. But still using (point-min) rather than 1.
Stefan