bug#2264: marked as done (Failed to build emacs 23.0.90 on Ubuntu 8.10 (x86_64))

[Emacs bug Tracking System]

Your message dated Fri, 6 Mar 2009 21:05:48 +0200
with message-id <1FAADEC4-9EF9-4518-B9FE-57295549C51F@gmail.com>
and subject line Re: Failed to build emacs 23.0.90 on Ubuntu 8.10 (x86_64)
has caused the Emacs bug report #2264,
regarding Failed to build emacs 23.0.90 on Ubuntu 8.10 (x86_64)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2264: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2264
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Failed to build emacs 23.0.90 on Ubuntu 8.10 (x86_64)
>
>
>
>
> Date: 
>
> Tue, 10 Feb 2009 09:55:18 +0200
>
>
>
>
> User-agent: 
>
> Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.7 Emacs/22.2 (i486-pc-linux-gnu) MULE/5.0 (SAKAKI)
>
>
>
>
> Thank you for trying to build the GNUstep port.  I've been holding
> these changes for far too long.
>
> (I wonder why this message didn't get a bug number assigned?  Perhaps
> because it was posted to the newsgroup first...)
>
>
> 2009-02-10  Yavor Doganov  <yavor@gnu.org>  (tiny change)
>
>         * nsterm.m: Include <signal.h>.
>
>         * nsfns.m (ns_appkit_version_int): Fix typo in the version macro.
>
> Index: src/nsfns.m
> ===================================================================
> RCS file: /sources/emacs/emacs/src/nsfns.m,v
> retrieving revision 1.36
> diff -u -r1.36 nsfns.m
> --- src/nsfns.m 23 Jan 2009 09:58:03 -0000      1.36
> +++ src/nsfns.m 10 Feb 2009 07:47:51 -0000
> @@ -974,7 +974,7 @@
>  ns_appkit_version_int ()
>  {
>  #ifdef NS_IMPL_GNUSTEP
> -  return GNUSTEP_GUI_MAJOR_VERSION * 100 + GNUSTEP_GNU_MINOR_VERSION;
> +  return GNUSTEP_GUI_MAJOR_VERSION * 100 + GNUSTEP_GUI_MINOR_VERSION;
>  #elif defined(NS_IMPL_COCOA)
>    return (int)NSAppKitVersionNumber;
>  #endif
> Index: src/nsterm.m
> ===================================================================
> RCS file: /sources/emacs/emacs/src/nsterm.m,v
> retrieving revision 1.58
> diff -u -r1.58 nsterm.m
> --- src/nsterm.m        7 Feb 2009 11:04:07 -0000       1.58
> +++ src/nsterm.m        10 Feb 2009 07:47:54 -0000
> @@ -30,6 +30,7 @@
>  #include "config.h"
>  
>  #include <math.h>
> +#include <signal.h>
>  #include <sys/types.h>
>  #include <time.h>
>  #include <unistd.h>
>
>
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Failed to build emacs 23.0.90 on Ubuntu 8.10 (x86_64)
>
>
>
>
> Date: 
>
> Fri, 6 Mar 2009 21:05:48 +0200
>
>
>
>
> > > Regarding the signal.h include in nsterm, can you provide some
> > > background or a mailing list archive link as to why it is needed?
> >
> > This is where the signal names are defined on glibc-based systems:
>
> OK, thanks, this must be for the SIGTERM use in ns_term_shutdown.  On  
> OS X it must already come in from somewhere, so including it will do  
> no harm.  I'm checking it in.
>
> You should still send the papers in though so we can use further  
> stuff you come up with in the future.
>
> ;)
>
>
>
> --- End Message ---