bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#788: menu indications of key bindings for remapped commands


From: Drew Adams
Subject: bug#788: menu indications of key bindings for remapped commands
Date: Sun, 15 Mar 2009 12:33:38 -0700

> From: Chong Yidong Sent: Sunday, March 15, 2009 11:00 AM
> > As described in:
> > http://lists.gnu.org/archive/html/emacs-devel/2007-05/msg01020.html
> > key bindings defined via remap look odd in menus.
> 
> I changed the code so that [remap foo] commands are not 
> displayed in the menus.
> 
> Ideally, we would follow the remappings, but I think this 
> could mess up the menu cache (e.g., if the remapped-to
> command is rebound).  So that's a larger, post-release project.

I haven't tried after your fix, but from your description of the fix, (a) the
bug is not fixed at all, and (b) the change is negative.

1. It is inappropriate to *remove* such commands (menu items) from the menu. Or
did you mean just remove the confusing key bindings from the menu items?

The latter would be OK as a temporary workaround, but it represents a loss of
information, and it does not fix the bug. To fix the bug, the real, user-level
key binding needs to be shown.


2. The bug needs to be fixed properly, as Richard requested two years ago. It's
inappropriate to just close it now with a statement that we are too close to the
release to fix it properly.

The goal should be to improve Emacs by fixing bugs, not simply to reduce the bug
count by closing bugs without fixing them.

If you want to keep this bug open and fix it sometime after the release, that
would be appropriate, but closing it with a non-fix fix is inappropriate.








reply via email to

[Prev in Thread] Current Thread [Next in Thread]