bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#2801: marked as done (23.0.90; ls-lisp-insert-directory: Variable b


From: Emacs bug Tracking System
Subject: bug#2801: marked as done (23.0.90; ls-lisp-insert-directory: Variable binding depth exceeds max-specpdl-size)
Date: Fri, 27 Mar 2009 18:45:03 +0000

Your message dated Fri, 27 Mar 2009 21:34:41 +0300
with message-id <u4oxen7b2.fsf@gnu.org>
and subject line Re: bug#2801: 23.0.90; ls-lisp-insert-directory: Variable 
binding depth exceeds        max-specpdl-size
has caused the Emacs bug report #2801,
regarding 23.0.90; ls-lisp-insert-directory: Variable binding depth exceeds 
max-specpdl-size
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
2801: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=2801
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
--- Begin Message --- Subject: 23.0.90; ls-lisp-insert-directory: Variable binding depth exceeds max-specpdl-size Date: Fri, 27 Mar 2009 08:13:28 -0700
emacs -Q
 
C-x 4 d, then enter -alFR and the name of a directory that has a few
subdirectory levels. The error message appears after a few seconds.
 
However, using -alR works fine.
 
The same bug is in Emacs 22.3.
 

In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600)
 of 2009-02-01 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
 
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENU
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t
 
Major mode: Dired by name
 
Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
 
Recent input:
C-u C-x 4 d F R <return> C O N T R I B <return> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <menu-bar> <help-menu> <send-emacs-bug
-report>
 
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
ls-lisp-insert-directory: Variable binding depth exceeds max-specpdl-size




--- End Message ---
--- Begin Message --- Subject: Re: bug#2801: 23.0.90; ls-lisp-insert-directory: Variable binding depth exceeds max-specpdl-size Date: Fri, 27 Mar 2009 21:34:41 +0300
> From: "Drew Adams" <drew.adams@oracle.com>
> Date: Fri, 27 Mar 2009 08:13:28 -0700
> Cc: 
> 
> emacs -Q
>  
> C-x 4 d, then enter -alFR and the name of a directory that has a few
> subdirectory levels. The error message appears after a few seconds.
>  
> However, using -alR works fine.

Thanks.  Fixed with the following change:

2009-03-27  Eli Zaretskii  <eliz@gnu.org>

        * ls-lisp.el (ls-lisp-insert-directory): Allow for a trailing '/'
        when looking for "." and "..".  (Bug#2801)

Index: lisp/ls-lisp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/ls-lisp.el,v
retrieving revision 1.81
retrieving revision 1.82
diff -u -r1.81 -r1.82
--- lisp/ls-lisp.el     28 Jan 2009 19:01:42 -0000      1.81
+++ lisp/ls-lisp.el     27 Mar 2009 18:34:03 -0000      1.82
@@ -390,7 +390,10 @@
              (setq elt (car file-alist)
                    file-alist (cdr file-alist))
              (when (and (eq (cadr elt) t) ; directory
-                        (not (string-match "\\`\\.\\.?\\'" (car elt))))
+                        ;; Under -F, we have already decorated all
+                        ;; directories, including "." and "..", with
+                        ;; a /, so allow for that as well.
+                        (not (string-match "\\`\\.\\.?/?\\'" (car elt))))
                (setq elt (expand-file-name (car elt) dir))
                (insert "\n" elt ":\n")
                (ls-lisp-insert-directory


--- End Message ---

reply via email to

[Prev in Thread] Current Thread [Next in Thread]