bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#3303: delete-frame raises old (invisible) frame


From: Adrian Robert
Subject: bug#3303: delete-frame raises old (invisible) frame
Date: Mon, 18 May 2009 08:16:22 +0700


On May 18, 2009, at 3:43 AM, Stefan Monnier wrote:

in frame.c looks plain wrong and should probably just be deleted:
frame-selection is never intended to raise (or lower) any frame.
If this `raise' is really necessary, then it needs a much more extensive
comment justifying its presence.
Adrian, could you remove this code, or justify clearly why it's here?

I think it is there because we need to raise another (visible) frame when
a frame is deleted.  This is standard behavior (and sensible).

This is a behavior which depends on the window-management policy, so
it's the responsibility of the window-manager (which may even decide
that the focus should return to some other application, which would make
a lot of sense if the frame was created via $EDITOR=emacsclient).

So, I'd still want to know what undesirable behavior would happen under
NS if we don't call Fraise_frame here (and also, why it needs to be
called here rather than elsewhere).

The behavior that arose was that no other frame would be selected or have focus after a frame was deleted. NS is click-to-focus, and the user would have to click another one manually, which is wrong on this platform. There is no behavior built into the NS window manager to choose another application window to be active after the active one has been removed -- this is left to application code.

This can be put in the comment if it would clarify -- the thing is I did not and don't understand why other terms, W32 at least, don't need it as well.







reply via email to

[Prev in Thread] Current Thread [Next in Thread]