bug#3174: "italic" is underlined now (NS?)

[Adrian Robert]

> This is -Q, then M-x customize-face RET italic RET:

OK, no synthItal font is being returned from list() for Monaco, and I  
believe this causes ital face to be "rewritten" to use underline as  
the next available emphasis method if no italic is available.

The problem is the if () at nsfont.m: 505 is not firing.

Can you try changing the line just above where family is set to

family = ns_get_family (font_spec);

If that does NOT fix it (see below for what you should see in the  
console output) then could you experiment to find out what other  
condition is causing the if () not to fire?

If it DOES fix it it must be a Leopard difference.  I don't like  
calling ns_get_family() twice so I'll look into rewriting some  
function signatures to avoid this.



> ~/em23$ nextstep/Emacs.app/Contents/MacOS/Emacs -Q
> nsfont: list for fontspec:
>     #<font-spec ns nil Monaco nil iso10646-1 nil nil nil nil nil  
> nil nil ((:name . "Monaco"))>
> 2009-06-12 08:43:22.617 Emacs[2654:10b] Request covering families  
> for script: ''
> 2009-06-12 08:43:22.676 Emacs[2654:10b]     returning 287 families
> 2009-06-12 08:43:22.677 Emacs[2654:10b] Got desc NSCTFontDescriptor  
> <0x16446a0> = {
>     NSFontFamilyAttribute = Monaco;
> } and found 1 matching fonts from it:
> created font_entity:
>     #<font-entity ns apple Monaco nil iso10646-1 medium normal  
> normal 0 nil 100 0 ((:name . "Monaco"))>

Should now have:

created font_entity:
    #<font-entity ns apple Monaco synthItal iso10646-1 medium italic  
normal 0 nil 0 0 ((:name . "Monaco"))>
    Returning 2 entities.