bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#3462: Auto-fill VC log contents


From: Lluis Vilanova
Subject: bug#3462: Auto-fill VC log contents
Date: Sun, 14 Jun 2009 22:58:10 +0200
User-agent: Mutt/1.5.18 (2008-05-17)

El Thu, Jun 04, 2009 at 12:14:47PM -0400, Stefan Monnier ens deleit� amb les 
seg�ents paraules:
> > (I think that modifying `add-change-log-entry' and related functions
> > to accept a destination buffer instead of a file would be valuable, so
> > changes can be directly pushed into the `VC-log' buffer)
> 
> Thank you.  Indeed, making add-log use the *VC-log* buffer (when it
> exists and when there's no ChangeLog file) would be a very welcome
> addition.  I believe it would provide the same functionality as your
> log-edit-fill, but more generic and better integrated.
> 
> If you can cook up a patch for it, we would definitely consider it for
> inclusion in Emacs-23.2

Yay! Attached is a patch to both add-log and log-edit. Note that a few TODO's
are marked along add-log code where I couldn't understand what the code was
doing (just started to learn elisp... well, in fact just switched into emacs 
:)).

The major show-stoppers right now are:

* Couldn't get change-log-minor-mode to highlight the text as in
  change-log-mode.
* Would be nice to allow adding entries to the bottom of current change log
  block instead of the top.
* diff-add-change-log-entries-other-window has a somewhat strange behaviour and
  ends up showing two windows with the same Changelog/VC-log buffer (I think the
  bug was already there).

See that some changes were made into log-edit to seamlessly integrate with this
new feature in add-log.

As always, comments are welcome.

apa!

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth

Attachment: change-log-use-buffer.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]