bug#3646: 23.0.95; bookmark format upgrade is incorrect

[Drew Adams]

(defun bookmark-upgrade-version-0-alist (old-list)
  "Upgrade a version 0 alist OLD-LIST to the current version."
  (mapcar
   (lambda (bookmark)
     (let* ((name...))
       (list
        name
        `((filename             .    ,filename)
          (front-context-string .    ,(or front-str ""))
          (rear-context-string  .    ,(or rear-str  ""))
          (position             .    ,position)
          (annotation           .    ,ann)))))
   old-list))
 
The bookmark entry format being output by that code is this:
 
(NAME ((filename . FILE)
       (front-context-string . FRONT-STR)
       (rear-context-string  . REAR-STR)
       (position . POS)
       (annotation . ANNOTATION)))
 
And that is what is called the "old deprecated" format in the doc
string of `bookmark-alist'.  Upgrade should upgrade to the latest
format, not an old, deprecated one.
 
Further, "the old deprecated one" should be replaced by a precise
reference to the last Emacs version that _produced_ such a deprecated
format.  Things are currently doubly confusing because we "upgrade"
from the bookmark version 0 format to an "old deprecated" format - and
there is yet a third format: the current format.
 
 
In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600)
 of 2009-06-19 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'