bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#4240: 23.1.50; C-u doesn't work with Swedish characters


From: Juri Linkov
Subject: bug#4240: 23.1.50; C-u doesn't work with Swedish characters
Date: Sun, 23 Aug 2009 21:54:04 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)

> I hit "C-u ä" expecting it to come out as "ääää".  Instead it comes out
> as "ä\344\344ä".  I try "C-u C-u ä" and it comes out as "ä" followed by
> fourteen "\344" and then a trailing "ä".  This happens no matter which
> kind of repetition I'm doing, be it using C-u or using e.g. M-3.  It's
> always the leading and the trailing character that come out right, all
> of the other ones are "broken".

Please see bug#4037:
http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4037

I received no confirmation that my proposed fix is correct.

Maybe the right fix is to reverse negation?  It seems logical to check
if a buffer is unibyte before converting from unibyte to multibyte, but
I don't understand what this code was supposed to do.

Index: src/cmds.c
===================================================================
RCS file: /sources/emacs/emacs/src/cmds.c,v
retrieving revision 1.107
diff -u -r1.107 cmds.c
--- src/cmds.c  13 Jul 2009 01:02:51 -0000      1.107
+++ src/cmds.c  10 Aug 2009 22:54:02 -0000
@@ -337,7 +337,7 @@
        /* Add the offset to the character, for Finsert_char.
           We pass internal_self_insert the unmodified character
           because it itself does this offsetting.  */
-       if (! NILP (current_buffer->enable_multibyte_characters))
+       if (NILP (current_buffer->enable_multibyte_characters))
          modified_char = unibyte_char_to_multibyte (modified_char);
 
        XSETFASTINT (n, XFASTINT (n) - 2);

-- 
Juri Linkov
http://www.jurta.org/emacs/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]