bug#1193: marked as done (23.0.60; doc string of bookmark-set)

[Emacs bug Tracking System]

Your message dated Sun, 04 Oct 2009 21:47:40 -0400
with message-id <87vdiumx1f.fsf@red-bean.com>
and subject line Fixed "doc string of bookmark-set"
has caused the Emacs bug report #1193,
regarding 23.0.60; doc string of bookmark-set
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1193: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1193
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 23.0.60; doc string of bookmark-set
>
>
>
>
> Date: 
>
> Fri, 17 Oct 2008 09:01:24 -0700
>
>
>
>
> The doc string says:
>  
>  Typing C-u inserts the name of the last bookmark used in the buffer
>  (as an aid in using a single bookmark name to track your progress
>  through a large file).  If no bookmark was used, then C-u inserts the
>  name of the file being visited.
>  
> This is unclear - "inserts...in the buffer" can give the impression
> that the last bookmark that was used (anywhere) is inserted in the
> (current) buffer. Even if you figure out that it means that it is the
> last bookmark that was used in the (current) buffer that is inserted,
> it's not clear where that is inserted. And in fact it is inserted
> nowhere - it is simply provided as the default value for the bookmark
> name.
>  
> Also, is it correct for the doc string to say this?
>  
>  Set a bookmark named NAME inside a file.
>  
> Why "inside a file"? Nowadays you can set bookmarks in Info
> etc. (granted, ultimately that is a file, but it is not what the doc
> string suggests).
>  
> Also, no reason to quote "push" in the doc string.
>  
>  
>  
> In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600)
>  of 2008-10-03 on LENNART-69DE564
> Windowing system distributor `Microsoft Corp.', version 5.1.2600
> configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include
> -fno-crossjumping'
>  
>
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Fixed "doc string of bookmark-set"
>
>
>
>
> Date: 
>
> Sun, 04 Oct 2009 21:47:40 -0400
>
>
>
>
> fixed
> --
>
> Thanks for the report.  Fix committed:
>
>   $ cvs ci -F msg lisp/bookmark.el lisp/ChangeLog
>   /sources/emacs/emacs/lisp/bookmark.el,v  <--  lisp/bookmark.el
>   new revision: 1.129; previous revision: 1.128
>   /sources/emacs/emacs/lisp/ChangeLog,v  <--  lisp/ChangeLog
>   new revision: 1.16355; previous revision: 1.16354
>   Mailing notification to emacs-diffs@gnu.org... sent.
>   $ 
>
> --- End Message ---