bug#4765: 23.1; set-frame-name makes emacs -nw crash on mac

[Chong Yidong]

Adrian Robert <adrian.b.robert@gmail.com> writes:

> On Oct 23, 2009, at 11:46 AM, Chong Yidong wrote:
>
>> Hi Adrian, can you reproduce this problem?
>
> I can on Snow Leopard and Tiger but this is in -nw mode and the stack
> trace (below) shows nothing involved from NS side.  Does it appear
> under other OS's?  The stack trace below shows it resulting from
> ns_set_name() called from x_implicitly_set_name.  ns_set_name does not
> check if it is an ns frame, but the X equivalent doesn't either.  It
> seems like something is going wrong earlier if x_implicitly_set_name
> is being called for a non-GUI frame.

No crash for me on GNU/Linux.  The x_implicity_set_name function *is*
called, but because `f->explicit_name' is non-zero (it's 1), that
function returns.

I think the problem is that ns_set_name should defer calling
FRAME_NS_VIEW until after line 542.  Maybe that fixes the bug; could you
check?