bug#4429: purecopy calls needed for :help and in menu-bar.el

[Dan Nicolaescu]

Juri Linkov <juri@jurta.org> writes:

  > >   > >> Does anyone know a reason why one menu item in menu-bar.el
  > >   > >> (`separator-exit') doesn't use the standard format with `menu-item'
  > >   > >> like all other menu items use?
  > >   > >
  > >   > > Accident?
  > >   >
  > >   > Probably.  Fixed.
  > >
  > > I think that a better fix would be to purecopy '("--"), there are >60
  > > instances of this in GC memory right when emacs starts up.
  > >
  > > Maybe define a constant menu-bar-standard-separator and use that
  > > everywhere?
  > 
  > I think a constant for "--" is a good idea.

Why not '("--"), it's an extra cons?

  > BTW, I just added a quote in 3 calls of `menu-bar-make-mm-toggle'
  > in menu-bar.el since this is necessary after your recent changes
  > in `menu-bar-make-mm-toggle'.

Sorry about that.

  > I hope that no code outside Emacs calls `menu-bar-make-mm-toggle'.
  > Otherwise, it will be broken.

Do you mean the menu-bar-make-mm-toggle is not incompatible with what it
was before?  Do you see a way to make it compatible?