bug#4927: marked as done (23.1; checkdoc-proper-noun-regexp with regexp-opt)

[Emacs bug Tracking System]

Your message dated Wed, 25 Nov 2009 10:13:43 +1100
with message-id <87zl6b349k.fsf@blah.blah>
and subject line Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt
has caused the Emacs bug report #4927,
regarding 23.1; checkdoc-proper-noun-regexp with regexp-opt
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
4927: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=4927
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> 23.1; checkdoc-proper-noun-regexp with regexp-opt
>
>
>
>
> Date: 
>
> Sun, 15 Nov 2009 08:44:28 +1100
>
>
>
>
> User-agent: 
>
> Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)
>
>
>
>
> This is the simplification I mentioned before for the way
> checkdoc-proper-noun-regexp is built.
>
> You'd be tempted to build the regexp within
> checkdoc-proper-noun-region-engine (maybe just with mapconcat) for
> easier customizing of checkdoc-proper-noun-list, but I suppose nobody
> changes it.
>
> 2009-11-13  Kevin Ryde  <user42@zip.com.au>
>
>         * emacs-lisp/checkdoc.el (checkdoc-proper-noun-regexp): Build
>         value with regexp-opt instead of explicit joining loop.
>
> --- checkdoc.el.~1.80.~ 2009-11-09 08:46:10.000000000 +1100
> +++ checkdoc.el 2009-11-09 09:33:33.000000000 +1100
> @@ -334,12 +334,9 @@
>    ;; "[.!?]" is for noun at end of a sentence, since those chars
>    ;; are symbol syntax in emacs-lisp-mode and so don't match \\_>.
>    ;; The \" allows it to be the last sentence in a docstring too.
> -  (let ((expr "\\_<\\(")
> -       (l checkdoc-proper-noun-list))
> -    (while l
> -      (setq expr (concat expr (car l) (if (cdr l) "\\|" ""))
> -           l (cdr l)))
> -    (concat expr "\\)\\(\\_>\\|[.!?][ \t\n\"]\\)"))
> +  (concat "\\_<"
> +         (regexp-opt checkdoc-proper-noun-list t)
> +         "\\(\\_>\\|[.!?][ \t\n\"]\\)")
>    "Regular expression derived from `checkdoc-proper-noun-regexp'.")
>  
>  (defvar checkdoc-common-verbs-regexp nil
>
>
>
> In GNU Emacs 23.1.1 (i486-pc-linux-gnu, GTK+ Version 2.16.5)
>  of 2009-09-14 on raven, modified by Debian
> configured using `configure  '--build=i486-linux-gnu' '--host=i486-linux-gnu' 
> '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' 
> '--localstatedir=/var/lib' '--infodir=/usr/share/info' 
> '--mandir=/usr/share/man' '--with-pop=yes' 
> '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.1/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/23.1/leim'
>  '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 
> 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -g 
> -O2' 'LDFLAGS=-g' 'CPPFLAGS=''
>
> Important settings:
>   value of $LC_ALL: nil
>   value of $LC_COLLATE: nil
>   value of $LC_CTYPE: nil
>   value of $LC_MESSAGES: nil
>   value of $LC_MONETARY: nil
>   value of $LC_NUMERIC: nil
>   value of $LC_TIME: nil
>   value of $LANG: en_AU
>   value of $XMODIFIERS: nil
>   locale-coding-system: iso-latin-1-unix
>   default-enable-multibyte-characters: t
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: bug#4927: 23.1; checkdoc-proper-noun-regexp with regexp-opt
>
>
>
>
> Date: 
>
> Wed, 25 Nov 2009 10:13:43 +1100
>
>
>
>
> User-agent: 
>
> Gnus/5.110011 (No Gnus v0.11) Emacs/23.1 (gnu/linux)
>
>
>
>
> Glenn Morris <rgm@gnu.org> writes:
> >
> > I think you should feel free to just install this kind of thing,
> > without needing to create a bug report.
>
> Done.
>
> --- End Message ---