bug#5148: marked as done (Lossage in comint history)

[Emacs bug Tracking System]

Your message dated Fri, 01 Jan 2010 13:45:32 -0500
with message-id <87y6kh8y0j.fsf@stupidchicken.com>
and subject line Re: Lossage in comint history
has caused the Emacs bug report #5148,
regarding Lossage in comint history
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact bug-gnu-emacs@gnu.org
immediately.)


-- 
5148: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5148
Emacs Bug Tracking System
Contact bug-gnu-emacs@gnu.org with problems
> --- Begin Message ---
>
>
>
> Subject: 
>
> Lossage in comint history
>
>
>
>
> Date: 
>
> Mon, 07 Dec 2009 19:27:34 +0200
>
>
>
>
> User-agent: 
>
> Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (x86_64-pc-linux-gnu)
>
>
>
>
> Using M-x shell in Emacs causes lossage in .bash_history.
>
> I set HISTFILESIZE and HISTSIZE to large values in .bashrc
> to not truncate the history file but comint.el disregards
> my settings and truncates the history file used by bash.
>
> The following patch make `comint-input-ring-size' customizable.
> The type should be `integer' because this value is used by `make-ring'
> to create the history ring.  The default value increased to 500
> to be the same as the default value of HISTFILESIZE and HISTSIZE.
>
> Index: lisp/comint.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/comint.el,v
> retrieving revision 1.402
> diff -c -r1.402 comint.el
> *** lisp/comint.el      1 Dec 2009 20:32:00 -0000       1.402
> --- lisp/comint.el      7 Dec 2009 17:27:08 -0000
> ***************
> *** 309,317 ****
>     :type 'integer
>     :group 'comint)
>   
> ! ;; FIXME: this should be defcustom
> ! (defvar comint-input-ring-size 150
> !   "Size of input history ring.")
>   
>   (defvar comint-input-ring-separator "\n"
>     "Separator between commands in the history file.")
> --- 309,319 ----
>     :type 'integer
>     :group 'comint)
>   
> ! (defcustom comint-input-ring-size 500
> !   "Size of input history ring."
> !   :type 'integer
> !   :group 'comint
> !   :version "23.2")
>   
>   (defvar comint-input-ring-separator "\n"
>     "Separator between commands in the history file.")
>
> -- 
> Juri Linkov
> http://www.jurta.org/emacs/
>
>
>
> --- End Message ---
> --- Begin Message ---
>
>
>
> Subject: 
>
> Re: Lossage in comint history
>
>
>
>
> Date: 
>
> Fri, 01 Jan 2010 13:45:32 -0500
>
>
>
>
> > Using M-x shell in Emacs causes lossage in .bash_history.
> >
> > I set HISTFILESIZE and HISTSIZE to large values in .bashrc
> > to not truncate the history file but comint.el disregards
> > my settings and truncates the history file used by bash.
> >
> > The following patch make `comint-input-ring-size' customizable.  The
> > type should be `integer' because this value is used by `make-ring' to
> > create the history ring.  The default value increased to 500 to be the
> > same as the default value of HISTFILESIZE and HISTSIZE.
>
> Looks reasonable enough to me.  Checked in, thanks.
>
>
> --- End Message ---