[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#5475: Archives with filenames with square brackets
From: |
Chong Yidong |
Subject: |
bug#5475: Archives with filenames with square brackets |
Date: |
Wed, 27 Jan 2010 11:57:46 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1.91 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
> First, why not use shell-quote-argument, instead of requiring comint?
I wasn't sure whether it was only [] that was handled specially, or the
usual shell wildcards. But I see now that it is the latter, as you say.
So shell-quote-argument is indeed the correct thing.
> Second, could someone please see if pkzip also expands wildcards
> internally? If it does not, the quoting will need to be done only in
> the non-pkzip branch. We also need to test this on MS-Windows.
I have no way to check this. Looks like pkzip is Windows-only.
> But most importantly, this patch is not clean, IMO: it hardcodes into
> archive-zip-extract (the function) some knowledge of what can be the
> possible values of archive-zip-extract the defcustom. What if
> tomorrow there will be a 3rd possibility, in addition to pkzip and
> unzip?
>
> That is why I thought about some less trivial patch: add to the data
> structures that are values of these defcustom's a flag to indicate
> whether the file name needs to be quoted or not.
Well, archive-zip-extract already branches for pkzip/unzip, so whatever
uncleanliness that's associated with is already present...
- bug#5475: Archives with filenames with square brackets, Juri Linkov, 2010/01/25
- bug#5475: Archives with filenames with square brackets, Chong Yidong, 2010/01/26
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/26
- bug#5475: Archives with filenames with square brackets,
Chong Yidong <=
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/27
- bug#5475: Archives with filenames with square brackets, Chong Yidong, 2010/01/28
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/28
- bug#5475: Archives with filenames with square brackets, Lennart Borgman, 2010/01/28
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/28
- bug#5475: Archives with filenames with square brackets, Juri Linkov, 2010/01/30
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/30
- bug#5475: Archives with filenames with square brackets, Juri Linkov, 2010/01/31
- bug#5475: Archives with filenames with square brackets, Eli Zaretskii, 2010/01/31
- bug#5475: Archives with filenames with square brackets, Juri Linkov, 2010/01/31