bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#5766: 23.1.94; invisible pointer still highlights text


From: Jan Djärv
Subject: bug#5766: 23.1.94; invisible pointer still highlights text
Date: Tue, 30 Mar 2010 19:32:32 +0200
User-agent: Thunderbird 2.0.0.24 (X11/20100317)

Stefan Monnier skrev:
I like the new feature in 23.1.94 of having the mouse pointer turn
invisible when you are typing.  However, if text is set to highlight
when the pointer is over it, this still occurs when the invisible
pointer is over something.  This can be disorienting if you switch
contexts into a buffer that has this.  For example, if you're typing
away and then switch to gnus, info, or any of the other many places
where there is mouse-selectable text, some seemingly random text on the
screen may be highlighted because the invisible cursor is over it.  If
possible, it seems like any behavior triggered by the mouse pointer
being over something should be disabled when the mouse pointer is
invisible.

I will shortly fix this in the trunk.  Is this appropriate for 23.2 also
(Stefan or Yidong)?  Here's the patch:

+  if (f->pointer_invisible) return;
+
   if (NILP (Vmouse_highlight)
       || !f->glyphs_initialized_p)
     return;

[ I didn't know about this feature.  ]

It was added in July, there was some discussion about it in emacs-devel.

The `if' should be combined with the subsequent one, but other than that
I think it's OK to install for Emacs-23.2.


Ok, checked in to the emacs-23 branch.

        Jan D.






reply via email to

[Prev in Thread] Current Thread [Next in Thread]