[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#6256: 24.0.50; read-event in `repeat' command
From: |
Stefan Monnier |
Subject: |
bug#6256: 24.0.50; read-event in `repeat' command |
Date: |
Mon, 05 Jul 2010 00:45:37 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
> That does not happen, however, because of this restrictive `eq' test in the
> definition of function `repeat':
> (while (eq (read-event) repeat-repeat-char)
> (repeat repeat-arg))
> The event read will be something like this, for the wheel action:
> (wheel-down (#<window 8 on foo.el> 2051 (118 . 176) 158455015 nil
> 2051 (59 . 40) nil (26 . 2) (2 . 4)))
> I would think that we would want to change the test to this, or similar:
> (while (let ((evt (read-event)))
> (and (equal (event-basic-type evt) (event-basic-type
> repeat-repeat-char))
> (equal (event-modifiers evt) (event-modifiers
> repeat-repeat-char))))
> (repeat repeat-arg))
> And that seems to work OK. What do you think - is it reasonable to do
> that?
That sounds right, yes,
People, feel free to make such a change,
Stefan