bug#6660: xassert failure on make custom-deps

[Eli Zaretskii]

> From: Juanma Barranquero <lekktu@gmail.com>
> Date: Sat, 17 Jul 2010 02:38:22 +0200
> Cc: 
> 
> Package: emacs
> Severity: important
> Version: 24.0.50
> 
> After
> 
>   cd lisp
>   make custom-deps
> 
> or just while bootstrapping, I get a (repeatable) xassert failure on
> dispnew.c:adjust_frame_glyphs_for_frame_redisplay.

Confirmed.  "bzr bisect" blames this commit:

  cyd@stupidchicken.com-20100710185647-l4ex7uy98klo3a57
  revno: 100769
  committer: Chong Yidong <cyd@stupidchicken.com>
  branch nick: trunk
  timestamp: Sat 2010-07-10 14:56:47 -0400
  message:
    Adapt terminal frames to latest menu-bar changes.

    * frame.c (make_frame): Initialize menu_bar_lines and
    tool_bar_lines members.
    (make_initial_frame, make_terminal_frame): Initialize
    menu_bar_lines using value of menu-bar-mode.

    * msdos.c (IT_set_frame_parameters): Don't set menu-bar-lines.

The fact that matrix_dim.height and FRAME_LINES (f) differ by one
seems to agree with the diagnosis.

Can someone see if the same happens on GNU/Linux (you will need to
compile with "-DENABLE_CHECKING -DXASSERTS=1").