bug#6963: More usecases, patch attached

[Juanma Barranquero]

On Wed, Sep 29, 2010 at 08:09, Wolfgang Schnerring <wosc@wosc.de> wrote:

> But that it does not signal error
> situations via its exit status

It does in most cases.

> since emacsclient returns 0 no matter what.

That's not accurate. When emacsclient detects a problem with itself
(missing server file, error opening socket, etc.) it returns
EXIT_FAILURE (1). What it currently does not do, however, is returning
EXIT_FAILURE for errors passed back from Emacs.

> I've attached a patch that makes emacsclient exit with nonzero status
> when it receives an error message from Emacs -- it already *prints*
> "*ERROR*" in these cases, so I feel this makes a lot of sense.

Yes, it makes sense, because after -error the client's process is
deleted, so emacsclient exits immediately.

So, two questions remain:

- should this be considered a bug, and installed on emacs-23, or a new
feature, for the trunk?
- should emacsclient return 1 for these new errors, or a new error
code (2) to allow distinguishing them?

    Juanma