[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer
From: |
Stefan Monnier |
Subject: |
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer |
Date: |
Wed, 20 Oct 2010 12:13:08 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> I was about to install that change when I realized that this is
>> fundamentally not the right approach: since some of the buffers may have
>> changed name, the new list of matching buffers may be different (some
>> buffers that didn't match before may match now and vice-versa).
>>
>> So iswitchb-make-buflist is more correct. To deal with the problem of
>> ordering, we'll need to combine the two: call iswitchb-make-buflist to
>> get the new list of matches, and then use bufobjs to sort the new
>> iswitchb-buflist.
> My understanding seems to be:
> iswitchb-buflist already contains all buffers needed although its order
> can be modified by iswitchb-next/prev-match. That modified ordering info
> is lost after iswitchb-make-buflist. There may be new matches appearing
> due to buffer name changes but this is taken care of automatically by
> iswitchb-exhibit.
I see, so iswitchb-buflist contains all buffers, not just the ones that
match the current input?
In that case, my concern is indeed a non-issue and your patch
looks fine. Please install it.
Stefan
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/17
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Óscar Fuentes, 2010/10/17
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/17
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/18
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/19
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/20
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Óscar Fuentes, 2010/10/20
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/21
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer,
Stefan Monnier <=
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Leo, 2010/10/23
- bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/27
bug#7231: 23.3; Don't rebuild buffer list in iswitchb-visit-buffer, Stefan Monnier, 2010/10/17