[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and
From: |
Fran Litterio |
Subject: |
bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil |
Date: |
Fri, 22 Oct 2010 11:03:44 -0400 |
To reproduce the bug do this:
1. Launch "emacs -q".
2. Type: ESC ESC : (icomplete-mode 1) RET C-h v mini TAB TAB
Notice that minibuffer-complete (which is bound to TAB at this point)
is cycling through the completion choices instead of popping up a
window to display the completion choices. This bug is caused code in
lisp/minibuffer.el that does not check that the value of
completion-cycle-threshold is not nil before deciding to cycle
completions. This patch (to the Bazaar sources) fixes the bug:
--- lisp/minibuffer.el.orig 2010-10-21 17:55:46.380857900 -0400
+++ lisp/minibuffer.el 2010-10-22 10:29:29.188417500 -0400
@@ -607,7 +607,8 @@
(completion-all-sorted-completions))))
(setq completion-all-sorted-completions nil)
(cond
- ((and (not (ignore-errors
+ ((and completion-cycle-threshold ;; Never cycle if
completion-cycle-threshold is nil.
+ (not (ignore-errors
;; This signal an (intended) error if comps is too
;; short or if completion-cycle-threshold is t.
(consp (nthcdr completion-cycle-threshold comps))))
@@ -664,7 +665,8 @@
(scroll-other-window))
nil)))
;; If we're cycling, keep on cycling.
- (completion-all-sorted-completions
+ ((and completion-cycle-threshold ;; Never cycle if
completion-cycle-threshold is nil.
+ completion-all-sorted-completions)
(minibuffer-force-complete)
t)
(t (case (completion--do-completion)
- bug#7266: Patch to fix minibuffer-complete when icomplete-mode is on and completion-cycle-threshold is nil,
Fran Litterio <=