[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#7859: syncing Emacs from sources maintained elsewhere
From: |
Eric Blake |
Subject: |
bug#7859: syncing Emacs from sources maintained elsewhere |
Date: |
Wed, 19 Jan 2011 17:27:47 -0700 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Mnenhy/0.8.3 Thunderbird/3.1.7 |
On 01/19/2011 03:38 AM, Paul Eggert wrote:
> * unexmacosx.c includes the Gnulib <unistd.h>.
That's always a bug to include any gnulib-provided header prior to
<config.h>.
>
> * And when Gnulib <getopt.h> declares a 'struct option', this clashes
> with the 'struct option' declared in the system getopt.h.
And this is a known symptom of violating the above constraint.
>
> PS. This all seems to be a case where we should be using Gnulib's
> identifier replacement mechanism, but I don't understand it that
> well and if memory serves it doesn't work with struct tags anyway.
We've managed to modernize other headers to properly declare replacement
structs exactly once; it is merely a matter of someone having enough
time to modernize the gnulib getopt module to use modern constructs
rather than abusing config.h to define an rpl_ prefix.
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- bug#7859: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/19
- Message not available
- Message not available
- bug#7856: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/19
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan Djärv, 2011/01/19
- bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/19
- bug#7859: syncing Emacs from sources maintained elsewhere, Eli Zaretskii, 2011/01/19
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan Djärv, 2011/01/20
- bug#7856: bug#7859: syncing Emacs from sources maintained elsewhere, Paul Eggert, 2011/01/20
- bug#7859: syncing Emacs from sources maintained elsewhere, Jan D., 2011/01/20
- bug#7859: syncing Emacs from sources maintained elsewhere,
Eric Blake <=