[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#8911: bs-cycle-next deletes window in some cases.
From: |
Stefan Monnier |
Subject: |
bug#8911: bs-cycle-next deletes window in some cases. |
Date: |
Tue, 28 Jun 2011 23:27:22 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> I'm not sure about the third (isn't it also fixed by passing a non-nil
>> arg to bury-buffer?)
> Well, yes, but that means "fixing" it everywhere; I mean:
> emacs -Q
> M-: (set-window-dedicated-p (selected-window) t) <RET>
> M-x bury-buffer <RET>
> and the frame is iconified. It shouldn't.
As mentioned earlier, maybe the single-frame case is special, but I'd
really first like to know how you get into such a state. For any other
case, M-x bury-buffer RET *should* iconify the current frame if it shows
a single dedicated window (with the caveat that Drew wants it to delete
the frame instead).
> If switch-to-buffer is changed not to fallback on pop-to-buffer, why
> shouldn't it be called from elisp?
Because 99% of the calls are wrong (they just want to display
a specific buffer and the author did not consider what should happen if
called in a minibuffer-only frame or in a dedicated window).
> In the case of bs-cycle-next:
> (unless (window-dedicated-p (selected-window))
> ;; We don't want the frame iconified if the only window in the frame
> ;; happens to be dedicated
> (bury-buffer (current-buffer)))
> (switch-to-buffer next)
> the current switch-to-buffer causes the unwanted-splitting behavior.
> Changing it to pop-to-buffer-same-window, as its docstring suggests,
> would still cause the same problem.
Yes, bs-cycle-next would be one of the very rare cases where calling
switch-to-buffer is the right thing to do.
Stefan
- bug#8911: bs-cycle-next deletes window in some cases., (continued)
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/26
- bug#8911: bs-cycle-next deletes window in some cases., Stefan Monnier, 2011/06/26
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/26
- bug#8911: bs-cycle-next deletes window in some cases., martin rudalics, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., martin rudalics, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., martin rudalics, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/27
- bug#8911: bs-cycle-next deletes window in some cases.,
Stefan Monnier <=
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/28
- bug#8911: bs-cycle-next deletes window in some cases., Stefan Monnier, 2011/06/30
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/30
- bug#8911: bs-cycle-next deletes window in some cases., martin rudalics, 2011/06/29
- bug#8911: bs-cycle-next deletes window in some cases., Stefan Monnier, 2011/06/30
- bug#8911: bs-cycle-next deletes window in some cases., Juanma Barranquero, 2011/06/29
- bug#8911: bs-cycle-next deletes window in some cases., Drew Adams, 2011/06/29
- bug#8911: bs-cycle-next deletes window in some cases., Drew Adams, 2011/06/29
- bug#8911: bs-cycle-next deletes window in some cases., martin rudalics, 2011/06/30
- bug#8911: bs-cycle-next deletes window in some cases., Drew Adams, 2011/06/30