[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#2028: 23.0.60; (1) dired-guess-default should remove duplicates (2)
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#2028: 23.0.60; (1) dired-guess-default should remove duplicates (2) doc string |
Date: |
Mon, 11 Jul 2011 15:39:57 +0200 |
User-agent: |
Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) |
"Drew Adams" <drew.adams@oracle.com> writes:
> `dired-guess-default' returns a list of default shell commands
> appropriate for its input, FILES. It should remove duplicates from
> this list before returning it.
Ok; done.
> Also, the doc string is:
>
> "Guess a shell commands for FILES. Return command or list of commands.
> See `dired-guess-shell-alist-user'."
>
> This is not correct grammatically. Suggestion:
>
> "Return a shell command, or a list of such, appropriate for FILES.
> See `dired-guess-shell-alist-user'."
I've changed it to something like that.
> BTW (I didn't check the code - just a naive question): Why do we
> return sometimes a single command instead of a singleton list of that
> command? What is gained by this added complexity? Is there some
> calling code that *must* receive a command and not a list of commands?
I'm guessing somebody extended the function at some point.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#2028: 23.0.60; (1) dired-guess-default should remove duplicates (2) doc string,
Lars Magne Ingebrigtsen <=