bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local

[Juanma Barranquero]

> What's the best way to make this change?  Just say
>
> (make-variable-buffer-local 'var)
>
> after the `defvar', and then removing all the `make-local-variable'
> calls?

Yes.

BTW, it's a mystery to me why `revert-buffer-function' is not
automatically buffer-local, when every single package that sets it
does so locally; having a global non-nil revert-buffer-function does
not make any sense whatsoever.

But IMHO, neither changing `revert-buffer-function' nor
`dired-subdir-alist' and `dired-directory' is really a bug fix. Yes,
as they are now is error prone, but the uses in the sources are
already correct. That should be a wishlist item for 24.2.

    Juanma