bug#7112: 24.0.50; [PATCH] `ls-lisp-insert-directory' should be no-op for empty FILE

[Lars Magne Ingebrigtsen]

"Drew Adams" <drew.adams@oracle.com> writes:

>> > (error "Args out of range: \"\", -1")
>> > The reason is the following code near the end of
>> > `ls-lisp-insert-directory':
>> 
>> I think this should most likely be fixed in the caller (i.e., in
>> dired.el).
>
> What does that mean?  dired.el is a file, not a caller.

dired.el should not be asking ls-lisp to list a directory called "",
which is obviously something that should generate an error.

>> What's the backtrace for this bug?
>
> Why not try it yourself, using the emacs -Q recipe:
>
> M-: (dired '("foobar" "111.el" ""))

Why would you call this function with an empty string as a parameter?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/