bug#9663: 23.2; feature wish: put priority on vcursor overlay

[Kevin Rodgers]

On 10/3/11 1:48 PM, Hendrik Tews wrote:
> the vcursor is invisible in the locked regions of Proof General,
> because the overlay of the locked region has priority 100 and the
> vcursor overlay has no priority set.
>
> Below I attach a patch that adds a defcustom
> vcursor-overlay-priority to the vcursor package, which fixes this
> problem. (I hereby assign copyright in this patch to the emacs
> project/FSF.)

Wouldn't nil be a better default value than 500?

> *** vcursor-23.2.el     2011-10-03 21:33:10.000000000 +0200
> --- vcursor.el  2011-10-03 21:29:59.000000000 +0200
> *************** scrolling set this.  It is used by the `
> *** 508,513 ****
> --- 508,521 ----
>      :type 'boolean
>      :group 'vcursor)
>
> + (defcustom vcursor-overlay-priority 500
> +   "Priority of the overlay that symbolizes the vcursor.
> + Increase this value if the vcursor becomes invisible when moving
> + into other specifically colored regions of text."
> +   :type 'integer
> +   :group 'vcursor
> +   :version "23.4")
> +
>    (defvar vcursor-temp-goal-column nil
>      "Keeps track of temporary goal columns for the virtual cursor.")
>
> *************** another window.  With LEAVE-W, use the c
> *** 657,663 ****
>          (or window-system
>            (display-color-p)
>            (overlay-put vcursor-overlay 'before-string vcursor-string))
> !       (overlay-put vcursor-overlay 'face 'vcursor))
>        (or leave-w (vcursor-find-window nil t))
>        ;; vcursor-window now contains the right buffer
>        (or (pos-visible-in-window-p pt vcursor-window)
> --- 665,672 ----
>          (or window-system
>            (display-color-p)
>            (overlay-put vcursor-overlay 'before-string vcursor-string))
> !       (overlay-put vcursor-overlay 'face 'vcursor)
> !       (overlay-put vcursor-overlay 'priority vcursor-overlay-priority))
>        (or leave-w (vcursor-find-window nil t))
>        ;; vcursor-window now contains the right buffer
>        (or (pos-visible-in-window-p pt vcursor-window)


--
Kevin Rodgers
Denver, Colorado, USA