bug#9793: 24.0.90; Unwanted tramp connection on eshell completion.

[Thierry Volpiatto]

Michael Albinus <michael.albinus@gmx.de> writes:

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> Because you didn't load tramp.
>>> Connect first to your "trex" or anything else, then close this, and run
>>> eshell and retry the above.
>>> For me too, if i start emacs -Q and i go strait to eshell, all work fine.
>>
>> Ah, I see, I can reproduce it now:
>>
>>    % emacs -Q
>>    M-x load-library RET tramp RET
>>    M-x eshell RET
>>    cd /t TAB
>>
>> At that point, Tramp tried to connect to `tic' and to `tequila' (the
>> hosts mentioned in ~/.ssh/known_hosts that start with `t').
>
> `pcomplete-dirs' uses `file-directory-p' as predicate, which is applied
> to all completion candidates. The following patch ought to fix it:
>
> *** /home/albinus/src/emacs/lisp/pcomplete.el.~106161~        2011-10-22 
> 11:31:11.996458454 +0200
> --- /home/albinus/src/emacs/lisp/pcomplete.el 2011-10-22 11:30:20.796204566 
> +0200
> ***************
> *** 948,954 ****
>   
>   (defsubst pcomplete-dirs (&optional regexp)
>     "Complete amongst a list of directories."
> !   (pcomplete-entries regexp 'file-directory-p))
>   
>   ;; generation of completion lists
>   
> --- 948,957 ----
>   
>   (defsubst pcomplete-dirs (&optional regexp)
>     "Complete amongst a list of directories."
> !   (pcomplete-entries regexp
> !                  (lambda (dir)
> !                    (or (file-remote-p (expand-file-name dir))
> !                        (file-directory-p dir)))))
>   
>   ;; generation of completion lists
>   
>
> Comments?
Work fine here, thank you very much.

-- 
  Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997