bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#9750: 24.0.90; Windows binary distribution build fails with 24.0.90


From: Christoph Scholtes
Subject: bug#9750: 24.0.90; Windows binary distribution build fails with 24.0.90 Pretest
Date: Sat, 04 Feb 2012 16:23:00 -0700
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20120129 Thunderbird/10.0

On 10/18/2011 9:47 AM, Stefan Monnier wrote:
It seems this change was made over a year ago, but a few months later
make-dist was changed to explicitly exclude this file. The question mark
on the end of the comment seems to indicate that the author of the
change wasn't sure at the time if it was the right thing to do.

Please just move the file to `nt', and rework the first few sentences to
make it clear in which context it is meant to be used.

Here is a proposed change to make the intent of the README.W32 file clearer if it comes in the Emacs sources distribution. The change to make-dist includes the file again in the source tarball. The fact that it does not right now is a major pain when trying to automate building the distribution from a source tarball.

Christoph

=== modified file 'nt/README.W32'
--- nt/README.W32       2012-01-26 21:37:32 +0000
+++ nt/README.W32       2012-02-04 23:19:02 +0000
@@ -3,9 +3,15 @@

                           Emacs for Windows

-  This README file describes how to set up and run a precompiled
-  version of GNU Emacs for Windows.  This distribution can be found on
-  the ftp.gnu.org server and its mirrors:
+  This README.W32 file describes how to set up and run a precompiled
+  version of GNU Emacs for Windows.
+
+  Please note that if you have received this file as part of the Emacs
+  source distribution see the included README file on how to compile
+  Emacs for Windows.
+
+  This distribution can be found on the ftp.gnu.org server and its
+  mirrors:

        ftp://ftp.gnu.org/gnu/emacs/windows/


=== modified file 'make-dist'
--- make-dist   2012-01-19 07:21:25 +0000
+++ make-dist   2012-02-04 23:16:36 +0000
@@ -398,13 +398,12 @@
 (cd m4
  ln *.m4 ../${tempdir}/m4)

-## Exclude README.W32 because it is specific to pre-built binaries(?).
 echo "Making links to \`nt'"
 (cd nt
  ln emacs.manifest emacs.rc emacsclient.rc config.nt ../${tempdir}/nt
  ln emacs-src.tags nmake.defs gmake.defs subdirs.el ../${tempdir}/nt
  ln [a-z]*.bat [a-z]*.[ch] ../${tempdir}/nt
- ln ChangeLog INSTALL README makefile.w32-in ../${tempdir}/nt)
+ ln ChangeLog INSTALL README README.W32 makefile.w32-in ../${tempdir}/nt)

 echo "Making links to \`nt/inc' and its subdirectories"
 for f in `find nt/inc -type f -name '[a-z]*.h'`; do







reply via email to

[Prev in Thread] Current Thread [Next in Thread]