[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10773: set-variable can't change values of user options
From: |
Kevin Rodgers |
Subject: |
bug#10773: set-variable can't change values of user options |
Date: |
Fri, 10 Feb 2012 01:18:06 -0700 |
User-agent: |
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9.2.26) Gecko/20120129 Thunderbird/3.1.18 |
On 2/9/12 11:28 AM, Glenn Morris wrote:
Juri Linkov wrote:
Why users are allowed to change the value of `outline-mode-hook',
but not `outline-minor-mode-hook'?
The former is defined with (defvar ... "*...").
The latter is not defined anywhere, but as define-derived-mode says
about hooks and has been covered several times:
No problems result if this variable is not bound.
`add-hook' automatically binds it. (This is true for all hook variables.)
I would says it's not very useful to pass a hook to set-variable anyway,
since you need to type a lisp expression, and probably should use
an explicit add-hook statement.
Or allow add-hook (and remove-hook) to be called interactively, for convenience:
--- - 2012-02-10 01:14:16.000000000 -0700
+++ /tmp/subr.el 2012-02-10 01:13:17.000000000 -0700
@@ -1216,15 +1216,17 @@
unless the optional argument APPEND is non-nil, in which case
FUNCTION is added at the end.
-The optional fourth argument, LOCAL, if non-nil, says to modify
-the hook's buffer-local value rather than its default value.
-This makes the hook buffer-local if needed, and it makes t a member
-of the buffer-local value. That acts as a flag to run the hook
-functions in the default value as well as in the local value.
+The optional fourth argument, LOCAL, if non-nil or an interactive
+prefix arg, says to modify the hook's buffer-local value rather
+than its default value. This makes the hook buffer-local if
+needed, and it makes t a member of the buffer-local value. That
+acts as a flag to run the hook functions in the default value as
+well as in the local value.
HOOK should be a symbol, and FUNCTION may be any valid function. If
HOOK is void, it is first set to nil. If HOOK's value is a single
function, it is changed to a list of functions."
+ (interactive "SHook: \naFunction: \ni\nP")
(or (boundp hook) (set hook nil))
(or (default-boundp hook) (set-default hook nil))
(if local (unless (local-variable-if-set-p hook)
@@ -1264,8 +1266,10 @@
FUNCTION isn't the value of HOOK, or, if FUNCTION doesn't appear in the
list of hooks to run in HOOK, then nothing is done. See `add-hook'.
-The optional third argument, LOCAL, if non-nil, says to modify
-the hook's buffer-local value rather than its default value."
+The optional third argument, LOCAL, if non-nil (interactively,
+with prefix argument) says to modify the hook's buffer-local
+value rather than its default value."
+ (interactive "SHook: \naFunction: \nP")
(or (boundp hook) (set hook nil))
(or (default-boundp hook) (set-default hook nil))
;; Do nothing if LOCAL is t but this hook has no local binding.
--
Kevin Rodgers
Denver, Colorado, USA
- bug#10773: set-variable can't change values of user options, Juri Linkov, 2012/02/09
- bug#10773: set-variable can't change values of user options, Glenn Morris, 2012/02/09
- bug#10773: set-variable can't change values of user options,
Kevin Rodgers <=
- bug#10773: set-variable can't change values of user options, Juri Linkov, 2012/02/10
- bug#10773: set-variable can't change values of user options, Glenn Morris, 2012/02/10
- bug#10773: set-variable can't change values of user options, Glenn Morris, 2012/02/10
- bug#10773: set-variable can't change values of user options, Stefan Monnier, 2012/02/12
- bug#10773: set-variable can't change values of user options, Glenn Morris, 2012/02/12
- bug#10773: set-variable can't change values of user options, Stefan Monnier, 2012/02/12
bug#10773: set-variable can't change values of user options, Juri Linkov, 2012/02/20