bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11508: 24.1.50; Off-by-one error in xg_select?


From: Ken Brown
Subject: bug#11508: 24.1.50; Off-by-one error in xg_select?
Date: Sun, 20 May 2012 18:44:59 -0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1

On 5/19/2012 5:52 AM, Andreas Schwab wrote:
Jan Djärv<jan.h.d@swipnet.se>  writes:

So the question is, is it more effective to give select the exact value
(select works fine if nfds has a higher value than strictly neccessary),
or always increment by one in lines 78 and 83?

IMHO it doesn't hurt to be exact, and the patch removes an inconsistency
which makes it easier to understand the code.

So can I go ahead and make this change?  Jan, do you still object?

Ken






reply via email to

[Prev in Thread] Current Thread [Next in Thread]