bug#11547: 24.0.96; Was a line accidentally commented out in callproc.c?

[Jan Djärv]

Hello.

It sure looks like I messed up.  Can you restore the line?  I don't have bzr 
access right now.
I guess it needs to be done in the 24 branch also.

See bug#5238 (http://debbugs.gnu.org/cgi/bugreport.cgi?bug=5238) for its impact.

        Jan D.

23 maj 2012 kl. 17:03 skrev Ken Brown:

> In the course of trying to debug a Cygwin crash, I noticed that line 643 of 
> callproc.c is commented out.  This was done in bzr revision 103252, and it 
> seems pretty clear from the context of that change that it was done by 
> accident:
> 
> revno: 103252
> committer: Jan D <jan.h.d@swipnet.se>
> branch nick: trunk
> timestamp: Sun 2011-02-13 12:28:42 +0100
> message:
>  * callproc.c (Fcall_process):
>  * process.c (create_process): Replace Gtk with GConf in SIGPIPE
>  comment.
> modified:
>  src/ChangeLog
>  src/callproc.c
>  src/process.c
> diff:
> === modified file 'src/ChangeLog'
> --- src/ChangeLog       2011-02-13 00:16:28 +0000
> +++ src/ChangeLog       2011-02-13 11:28:42 +0000
> @@ -1,3 +1,9 @@
> +2011-02-13  Jan Djärv  <jan.h.d@swipnet.se>
> +
> +       * callproc.c (Fcall_process):
> +       * process.c (create_process): Replace Gtk with GConf in SIGPIPE
> +       comment.
> +
> 2011-02-12  Martin Rudalics  <rudalics@gmx.at>
> 
>        * window.c (select_window): Check inhibit_point_swap argument when
> 
> === modified file 'src/callproc.c'
> --- src/callproc.c      2011-02-12 18:53:24 +0000
> +++ src/callproc.c      2011-02-13 11:28:42 +0000
> @@ -559,9 +559,9 @@
>         setpgrp (pid, pid);
> #endif /* USG */
> 
> -       /* GTK causes us to ignore SIGPIPE, make sure it is restored
> +       /* GConf causes us to ignore SIGPIPE, make sure it is restored
>           in the child.  */
> -       signal (SIGPIPE, SIG_DFL);
> +       //signal (SIGPIPE, SIG_DFL);
> #ifdef HAVE_WORKING_VFORK
>        sigprocmask (SIG_SETMASK, &procmask, 0);
> #endif
> 
> === modified file 'src/process.c'
> --- src/process.c       2011-02-12 18:53:24 +0000
> +++ src/process.c       2011-02-13 11:28:42 +0000
> @@ -2056,7 +2056,7 @@
> 
>        signal (SIGINT, SIG_DFL);
>        signal (SIGQUIT, SIG_DFL);
> -       /* GTK causes us to ignore SIGPIPE, make sure it is restored
> +       /* GConf causes us to ignore SIGPIPE, make sure it is restored
>           in the child.  */
>        signal (SIGPIPE, SIG_DFL);
> 
> 
> I don't understand the code well enough to know how critical this is. The 
> comment preceding that line suggests that it could be a problem for a build 
> with GConf support.
> 
> Ken
> 
> 
>