[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12034: 24.1.50; pp-display-expression may select deleted window
From: |
Christopher Schmidt |
Subject: |
bug#12034: 24.1.50; pp-display-expression may select deleted window |
Date: |
Mon, 23 Jul 2012 15:04:32 +0100 (BST) |
In pp-display-expression there is this sexp:
(let ((temp-buffer-show-function old-show-function)
(old-selected (selected-window))
(window (display-buffer buf)))
^^^^^^^^^^^^^^^^^^^^
(goto-char (point-min)) ; expected by some hooks ...
(make-frame-visible (window-frame window))
(unwind-protect
(progn
(select-window window)
(run-hooks 'temp-buffer-show-hook))
(select-window old-selected)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
(message "See buffer %s." out-buffer-name)))
An user may implement an overriding action for display-buffer that could
delete old-selected.
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-07-22 21:14:12 +0000
+++ lisp/ChangeLog 2012-07-23 12:49:21 +0000
@@ -1,3 +1,8 @@
+2012-07-23 Christopher Schmidt <christopher@ch.ristopher.com>
+
+ * emacs-lisp/pp.el (pp-display-expression): Select old selected
+ window only if it is still live (Bug#).
+
2012-07-22 Vincent Belaïche <vincentb1@users.sourceforge.net>
* ses.el (ses-cell-formula-aset): New macro.
=== modified file 'lisp/emacs-lisp/pp.el'
--- lisp/emacs-lisp/pp.el 2012-02-05 02:09:35 +0000
+++ lisp/emacs-lisp/pp.el 2012-07-23 12:44:07 +0000
@@ -110,7 +110,8 @@
(progn
(select-window window)
(run-hooks 'temp-buffer-show-hook))
- (select-window old-selected)
+ (when (window-live-p old-selected)
+ (select-window old-selected))
(message "See buffer %s." out-buffer-name)))
(message "%s" (buffer-substring (point-min) (point)))
))))))
Christopher
- bug#12034: 24.1.50; pp-display-expression may select deleted window,
Christopher Schmidt <=