[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12463: 24.2; pos-visible-in-window-p gets slower over time
From: |
Chong Yidong |
Subject: |
bug#12463: 24.2; pos-visible-in-window-p gets slower over time |
Date: |
Fri, 21 Sep 2012 17:24:17 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> ! #ifdef HAVE_NTGUI
>> ! /* If we failed to load the library before, don't try again. */
>> ! Lisp_Object tested = Fassq (target_type, Vlibrary_cache);
>> ! if (CONSP (tested) && NILP (XCDR (tested)))
>> ! type_valid = 0;
>> ! else
>> ! #endif
>> ! {
>> ! /* If the load failed, avoid trying again. */
>> ! type_valid = (*type->init)(libraries);
>> ! CACHE_IMAGE_TYPE (target_type, type_valid);
>> ! }
>> ! }
>
> What will happen if 'tested' is not a cons cell?
If `tested' is not a cons cell, it must be nil, and the code proceeds
with the library initialization.
>> of `dynamic-library-alist', which see). */)
>> (Lisp_Object type, Lisp_Object libraries)
>> {
>> ! struct image_type *p = lookup_image_type (type, libraries);
>> ! return p ? *p->type : Qnil;
>> ! }
>
> This changes the return value of init-image-library; is there a good
> reason for not returning Qt here instead of the type symbol?
No good reason; we could return Qt here.
>> ! /* Look up image type SYMBOL, and return a pointer to its image_type
>> ! structure. Value is null if SYMBOL is not a known image type. */
>
> Again, LIBRARIES is not documented. Also, I believe we use NULL in
> caps elsewhere. And finally, the argument is called TYPE, not SYMBOL.
Thanks.
>> ! static struct image_type *
>> ! lookup_image_type (Lisp_Object type, Lisp_Object libraries)
>> ! {
>> ! if (NILP (libraries))
>> ! libraries = Vdynamic_library_alist;
>
> I can't say I like this "default". Why not always call
> lookup_image_type with Vdynamic_library_alist? For that matter, why
> not make lookup_image_type always use Vdynamic_library_alist without
> passing it through the call parameters?
This is simply following the existing practice of Finit_image_library.
I don't know why that function accepts a LIBRARIES argument, rather than
just making callers bind Vdynamic_library_alist.
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, (continued)
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Jörg Walter, 2012/09/18
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/20
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/20
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time,
Chong Yidong <=
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Stefan Monnier, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Stefan Monnier, 2012/09/21
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Stefan Monnier, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Juanma Barranquero, 2012/09/22
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Chong Yidong, 2012/09/23
- bug#12463: 24.2; pos-visible-in-window-p gets slower over time, Eli Zaretskii, 2012/09/22