[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB
From: |
Drew Adams |
Subject: |
bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB> |
Date: |
Fri, 28 Sep 2012 14:37:30 -0700 |
(kbd "M-<TAB>") incorrectly returns [M-TAB]. IMHO, it should return
[134217737], the same thing that (kbd "M-TAB") returns.
IOW, for consistency, TAB should be treated specially here, in the
same way that NUL, RET, LFD, ESC, SPC, and DEL are treated specially.
Yes, it is true that there is no predefined function key named `NUL'
etc. But there is also no predefined function key named `TAB'. The
predefined function key is named `tab', not `TAB'. `M-<tab>' is not the
same thing as `M-<TAB>', of course. It is better to help users avoid
such possible confusion by treating `TAB' the same way we treat `NUL' etc.
diff -c edmacro.el edmacro-patched.el
*** edmacro.el Fri Sep 28 13:55:18 2012
--- edmacro-patched.el Fri Sep 28 13:56:24 2012
***************
*** 708,714 ****
(substring word (match-beginning 3)
(match-end 3))))
(not (string-match
! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\)$"
word))))
(setq key (list (intern word))))
((or (equal word "REM") (string-match "^;;" word))
--- 708,714 ----
(substring word (match-beginning 3)
(match-end 3))))
(not (string-match
! "\\<\\(NUL\\|RET\\|LFD\\|ESC\\|SPC\\|DEL\\TAB\\)$"
word))))
(setq key (list (intern word))))
((or (equal word "REM") (string-match "^;;" word))
Diff finished. Fri Sep 28 13:56:44 2012
In GNU Emacs 24.2.50.1 (i386-mingw-nt5.1.2600)
of 2012-09-17 on MARVIN
Bzr revision: 110062 cyd@gnu.org-20120917054104-r93rtwkrtva73ewe
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
`configure --with-gcc (4.7) --no-opt --enable-checking --cflags
-ID:/devel/emacs/libs/libXpm-3.5.8/include
-ID:/devel/emacs/libs/libXpm-3.5.8/src
-ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
-ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
-ID:/devel/emacs/libs/giflib-4.1.4-1/include
-ID:/devel/emacs/libs/jpeg-6b-4/include
-ID:/devel/emacs/libs/tiff-3.8.2-1/include
-ID:/devel/emacs/libs/gnutls-3.0.9/include
-ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
-ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- bug#12535: 24.2.50; [PATCH] `edmacro-parse-keys' is incorrect for M-<TAB>,
Drew Adams <=