[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11580: [PATCH] Fix bug #11580
From: |
Sergio Durigan Junior |
Subject: |
bug#11580: [PATCH] Fix bug #11580 |
Date: |
Mon, 01 Oct 2012 23:50:44 -0300 |
On Monday, October 01 2012, Roland Winkler wrote:
> On Mon Oct 1 2012 Sergio Durigan Junior wrote:
>> Thanks, the patch is simpler. I took the liberty to make a small
>> correction on your patch, which is to call (error "Unknown BBDB
>> attribute") instead of (setq val "Unknown BBDB attribute"), which I
>> think is a better way to handle it.
>
> I omitted this because I think one needs to modify some deep
> internals of BBDB to get the "Unknown BBDB attribute".
> (Have you ever seen a situation where this code is relevant?)
I don't really remember.
> In that sense, I believe it should not matter what the code is doing
> here.
Well, I prefered to be cautious either way :-).
>> So, is the patch below OK for mailine?
>
> Can you install? Or should I do it?
It is my first patch to Emacs, so I don't think I have the necessary
permission to do so. I would appreciate if you could push it for me
(and also mark the related bug as closed).
Thank you,
--
Sergio