bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#12610: unable to use macro in defadvice


From: Glenn Morris
Subject: bug#12610: unable to use macro in defadvice
Date: Thu, 11 Oct 2012 22:05:43 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Interesting. Advice does not macroexpand the advice definition.
I guess it should?

*** lisp/emacs-lisp/advice.el   2012-09-14 13:44:31 +0000
--- lisp/emacs-lisp/advice.el   2012-10-12 02:02:39 +0000
***************
*** 3658,3664 ****
         (advice (ad-make-advice
                  name (memq 'protect flags)
                  (not (memq 'disable flags))
!                 `(advice lambda ,arglist ,@body)))
         (preactivation (if (memq 'preactivate flags)
                            (ad-preactivate-advice
                             function advice class position))))
--- 3658,3664 ----
         (advice (ad-make-advice
                  name (memq 'protect flags)
                  (not (memq 'disable flags))
!                 `(advice lambda ,arglist ,@(macroexpand-all body))))
         (preactivation (if (memq 'preactivate flags)
                            (ad-preactivate-advice
                             function advice class position))))






reply via email to

[Prev in Thread] Current Thread [Next in Thread]