[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#12632: file permissions checking mishandled when setuid
From: |
Paul Eggert |
Subject: |
bug#12632: file permissions checking mishandled when setuid |
Date: |
Fri, 19 Oct 2012 10:01:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:16.0) Gecko/20121011 Thunderbird/16.0.1 |
On 10/16/2012 09:36 AM, Eli Zaretskii wrote:
>> > I thought the point of Bug#12587 was that on Windows,
>> > 'stat' can be way slower than faccessat, so much
>> > so that Emacs appears unresponsive.
> Granted, I was talking only about Posix platforms.
I'd rather avoid the situation where we have code like this:
#if defined WINDOWSNT || defined __sun
use faccessat
#elif defined __linux__
use stat
#else
/* not sure which is faster */
#endif
unless there's a reasonably significant performance advantage
in doing so. The performance advantage of stat on GNU/Linux
is relatively minor, whereas the performance advantage of
faccessat on Windows is major. Since it's simpler to use faccessat
everywhere, I installed a patch to do that as trunk bzr 110591
and am marking this bug as done. In the unlikely event that we
run into significant performance issues because of this we can
easily switch to the more-complex approach.
- bug#12632: file permissions checking mishandled when setuid, (continued)
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/14
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/14
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/14
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/14
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/15
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/15
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/15
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/15
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/16
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/16
- bug#12632: file permissions checking mishandled when setuid,
Paul Eggert <=
- bug#12632: file permissions checking mishandled when setuid, Eli Zaretskii, 2012/10/19
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/19
- bug#12632: file permissions checking mishandled when setuid, Glenn Morris, 2012/10/19
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/19
- bug#12632: file permissions checking mishandled when setuid, Richard Stallman, 2012/10/19
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/20
- bug#12632: file permissions checking mishandled when setuid, Glenn Morris, 2012/10/20
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/20
- bug#12632: file permissions checking mishandled when setuid, Glenn Morris, 2012/10/21
- bug#12632: file permissions checking mishandled when setuid, Paul Eggert, 2012/10/22