bug#12970: 24.3.50; erc failing with undefined second

[john ffitch]

erc fails to start.  The backtraces are

Debugger entered--Lisp error: (void-function second)
  second(("jpff" "36" "IRC Operators online"))
  erc-server-252(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":zelazny.freenode.net 252 jpff 36 :IRC Operators online" 
"zelazny.freenode.net" "252" ("jpff" "36" "IRC Operators online") "IRC 
Operators online"])
  run-hook-with-args-until-success(erc-server-252 #<process 
erc-irc.freenode.net-6667> [cl-struct-erc-response ":zelazny.freenode.net 252 
jpff 36 :IRC Operators online" "zelazny.freenode.net" "252" ("jpff" "36" "IRC 
Operators online") "IRC Operators online"])
  erc-call-hooks(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":zelazny.freenode.net 252 jpff 36 :IRC Operators online" 
"zelazny.freenode.net" "252" ("jpff" "36" "IRC Operators online") "IRC 
Operators online"])
  erc-handle-parsed-server-response(#<process erc-irc.freenode.net-6667> 
[cl-struct-erc-response ":zelazny.freenode.net 252 jpff 36 :IRC Operators 
online" "zelazny.freenode.net" "252" ("jpff" "36" "IRC Operators online") "IRC 
Operators online"])
  erc-parse-server-response(#<process erc-irc.freenode.net-6667> 
":zelazny.freenode.net 252 jpff 36 :IRC Operators online")
  erc-server-filter-function(#<process erc-irc.freenode.net-6667> 
":zelazny.freenode.net 001 jpff :Welcome to the freenode Internet Relay Chat 
Network jpff\n:zelazny.freenode.net 002 jpff :Your host is 
zelazny.freenode.net[140.211.167.106/6667], running version 
ircd-seven-1.1.3\n:zelazny.freenode.net 003 jpff :This server was created Tue 
Sep 25 2012 at 08:51:49 UTC\n:zelazny.freenode.net 004 jpff 
zelazny.freenode.net ircd-seven-1.1.3 DOQRSZaghilopswz 
CFILMPQbcefgijklmnopqrstvz bkloveqjfI\n:zelazny.freenode.net 005 jpff 
CHANTYPES=# EXCEPTS INVEX CHANMODES=eIbq,k,flj,CFLMPQcgimnprstz CHANLIMIT=#:120 
PREFIX=(ov)@+ MAXLIST=bqeI:100 MODES=4 NETWORK=freenode KNOCK STATUSMSG=@+ 
CALLERID=g :are supported by this server\n:zelazny.freenode.net 005 jpff 
CASEMAPPING=rfc1459 CHARSET=ascii NICKLEN=16 CHANNELLEN=50 TOPICLEN=390 ETRACE 
CPRIVMSG CNOTICE DEAF=D MONITOR=100 FNC 
TARGMAX=NAMES:1,LIST:1,KICK:1,WHOIS:1,PRIVMSG:4,NOTICE:4,ACCEPT:,MONITOR: :are 
supported by this server\n:zelazny.freenode.net 005 jpff EXTBAN=$,arx WHOX 
CLIENTVER=3.0 SAFELIST ELIST=CTU :are supported by this 
server\n:zelazny.freenode.net 251 jpff :There are 211 users and 74577 invisible 
on 34 servers\n:zelazny.freenode.net 252 jpff 36 :IRC Operators 
online\n:zelazny.freenode.net 253 jpff 11 :unknown 
connection(s)\n:zelazny.freenode.net 254 jpff 42286 :channels 
formed\n:zelazny.freenode.net 255 jpff :I have 3306 clients and 1 
servers\n:zelazny.freenode.net 265 jpff 3306 3837 :Current local users 3306, 
max 3837\n:zelazny.freenode.net 266 jpff 74788 83497 :Current global users 
74788, max 83497\n:zelazny.freenode.net 250 jpff :Highest connection count: 
3838 (3837 clients) (474381 connections received)\n:zelazny.freenode.net 375 
jpff :- zelazny.freenode.net Message of the Day - \n:zelazny.freenode.net 372 
jpff :- Welcome to zelazny.freenode.net in Corvallis, Oregon, US. 
\n:zelazny.freenode.net 372 jpff :- Our thanks to Oregon State University for 
sponsoring this\n:zelazny.freenode.net 372 jpff :- 
server!\n:zelazny.freenode.net 372 jpff :-  \n:zelazny.freenode.net 372 jpff :- 
ZELAZNY, ROGER JOSEPH [1937-1995].  Roger Zelazny was a\n:zelazny.freenode.net 
372 jpff :- leading light in the New Wave of science fiction.  He 
began\n:zelazny.freenode.net 372 jpff :- writing in 1962.  Known for such works 
as This Immortal,\n:zelazny.freenode.net 372 jpff :- Lord of Light, The 
Dream Master and the Amber books,\n:zelazny.freenode.net 372 jpff :- Zelazny 
is best known for his idiomatic American\n:zelazny.freenode.net 372 jpff :- 
protagonists, embodying the mythological figures of the\n:zelazny.freenode.net 
372 jpff :- Trickster and the Hero of a Thousand Faces.\n:zelazny.freenode.net 
372 jpff :-  \n:zelazny.freenode.net 372 jpff :- You're using freenode, a 
service of Peer-Directed Projects\n:zelazny.freenode.net 372 jpff :- Center Ltd 
(http://freenode.net/pdpc.shtml).\n:zelazny.fr")



Debugger entered--Lisp error: (void-function second)
  second(("jpff" "11" "unknown connection(s)"))
  erc-server-253(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":zelazny.freenode.net 253 jpff 11 :unknown connection(s)" 
"zelazny.freenode.net" "253" ("jpff" "11" "unknown connection(s)") "unknown 
connection(s)"])
  run-hook-with-args-until-success(erc-server-253 #<process 
erc-irc.freenode.net-6667> [cl-struct-erc-response ":zelazny.freenode.net 253 
jpff 11 :unknown connection(s)" "zelazny.freenode.net" "253" ("jpff" "11" 
"unknown connection(s)") "unknown connection(s)"])
  erc-call-hooks(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":zelazny.freenode.net 253 jpff 11 :unknown connection(s)" 
"zelazny.freenode.net" "253" ("jpff" "11" "unknown connection(s)") "unknown 
connection(s)"])
  erc-handle-parsed-server-response(#<process erc-irc.freenode.net-6667> 
[cl-struct-erc-response ":zelazny.freenode.net 253 jpff 11 :unknown 
connection(s)" "zelazny.freenode.net" "253" ("jpff" "11" "unknown 
connection(s)") "unknown connection(s)"])
  erc-parse-server-response(#<process erc-irc.freenode.net-6667> 
":zelazny.freenode.net 253 jpff 11 :unknown connection(s)")
  erc-server-filter-function(#<process erc-irc.freenode.net-6667> "PING 
:zelazny.freenode.net\n")


Debugger entered--Lisp error: (void-function second)
  second(("jpff" "36" "IRC Operators online"))
  erc-server-252(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":wolfe.freenode.net 252 jpff 36 :IRC Operators online" "wolfe.freenode.net" 
"252" ("jpff" "36" "IRC Operators online") "IRC Operators online"])
  run-hook-with-args-until-success(erc-server-252 #<process 
erc-irc.freenode.net-6667> [cl-struct-erc-response ":wolfe.freenode.net 252 
jpff 36 :IRC Operators online" "wolfe.freenode.net" "252" ("jpff" "36" "IRC 
Operators online") "IRC Operators online"])
  erc-call-hooks(#<process erc-irc.freenode.net-6667> [cl-struct-erc-response 
":wolfe.freenode.net 252 jpff 36 :IRC Operators online" "wolfe.freenode.net" 
"252" ("jpff" "36" "IRC Operators online") "IRC Operators online"])
  erc-handle-parsed-server-response(#<process erc-irc.freenode.net-6667> 
[cl-struct-erc-response ":wolfe.freenode.net 252 jpff 36 :IRC Operators online" 
"wolfe.freenode.net" "252" ("jpff" "36" "IRC Operators online") "IRC Operators 
online"])
  erc-parse-server-response(#<process erc-irc.freenode.net-6667> 
":wolfe.freenode.net 252 jpff 36 :IRC Operators online")
  erc-server-filter-function(#<process erc-irc.freenode.net-6667> "PING 
:wolfe.freenode.net\n")

It looks as if the calls to second in erc/erc-backend.el should be
cadr or cl-second
==John ff


In GNU Emacs 24.3.50.9 (x86_64-suse-linux-gnu, GTK+ Version 3.4.4)
 of 2012-11-22 on harvey
Bzr revision: 110982 rgm@gnu.org-20121122111734-kj1dqycu4sx7pk7b
Windowing system distributor `The X.Org Foundation', version 11.0.11203000
Important settings:
  value of $LANG: en_GB.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  erc-track-mode: t
  erc-track-minor-mode: t
  erc-ring-mode: t
  erc-notify-mode: t
  erc-networks-mode: t
  erc-netsplit-mode: t
  erc-menu-mode: t
  erc-match-mode: t
  erc-list-mode: t
  erc-pcomplete-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-autojoin-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  auto-image-file-mode: t
  show-paren-mode: t
  display-time-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<return> <help-echo> <down-mouse-1> <mouse-movement> 
<mouse-movement> <help-echo> <mouse-movement> <mouse-movement> 
<help-echo> <mouse-movement> <mouse-movement> <mouse-movement> 
<mouse-movement> <drag-mouse-1> <help-echo> <help-echo> 
<help-echo> <help-echo> <switch-frame> <help-echo> 
C-x C-f / t m p / e r r <return> <down-mouse-2> <mouse-2> 
<return> <switch-frame> q <switch-frame> <down-mouse-4> 
<mouse-4> <double-down-mouse-4> <double-mouse-4> <triple-down-mouse-4> 
<triple-mouse-4> <triple-down-mouse-4> <triple-mouse-4> 
<triple-down-mouse-4> <triple-mouse-4> <triple-down-mouse-4> 
<triple-mouse-4> <triple-down-mouse-4> <triple-mouse-4> 
<down-mouse-4> <mouse-4> <switch-frame> <help-echo> 
<switch-frame> <help-echo> <down-mouse-1> <mouse-movement> 
<mouse-movement> <help-echo> <mouse-movement> <mouse-movement> 
<drag-mouse-1> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> 
<mouse-1> <mouse-1> <down-mouse-1> <mouse-movement> 
<mouse-1> <return> <return> <down-mouse-2> <mouse-2> 
<return> <return> <help-echo> <help-echo> q <backspace> 
<help-echo> <down-mouse-1> <mouse-1> q <help-echo> 
<switch-frame> <switch-frame> <help-echo> <switch-frame> 
<switch-frame> <down-mouse-1> <mouse-movement> <mouse-movement> 
<drag-mouse-1> <down-mouse-2> <mouse-2> <return> <return> 
<help-echo> q <backspace> <help-echo> <down-mouse-1> 
<mouse-1> q <help-echo> <switch-frame> <down-mouse-1> 
<mouse-movement> <mouse-1> <next> <down-mouse-1> <mouse-1> 
<switch-frame> ( d e f u n SPC s e c o n d SPC ( x 
) SPC ( c a d r SPC x ) ) C-x C-e <switch-frame> / 
j o i n SPC c s o u n d <return> <help-echo> <switch-frame> 
<switch-frame> <switch-frame> <help-echo> <help-echo> 
M-x r e p o r t <tab> <return>

Recent messages:
Invalid face reference: my-trailing-space-face [2 times]
Auto-saving...
Invalid face reference: my-trailing-space-face
Logging in as 'jpff'... done
Entering debugger...
Mark set
Back to top level.
Invalid face reference: my-trailing-space-face [17 times]
secondInvalid face reference: my-trailing-space-face
Invalid face reference: my-trailing-space-face [38 times]

Load-path shadows:
None found.

Features:
(shadow mailalias mailcrypt mail-extr emacsbug message rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils
help-mode debug network-stream starttls tls erc-track erc-ring
erc-notify erc-networks erc-netsplit erc-menu erc-match erc-pcomplete
pcomplete comint ansi-color ring erc-button erc-fill erc-stamp
wid-edit erc-join erc-goodies erc erc-backend erc-compat format-spec
auth-source eieio byte-opt bytecomp byte-compile cconv gnus-util
mm-util mail-prsvr password-cache thingatpt pp eldoc help-fns
cal-julian image-file crypt crypt++ crypt+pgp-pub paren uniquify
nadvice view mule-util cal-china cal-bahai cal-islam cal-hebrew lunar
solar cal-dst appt diary-lib diary-loaddefs holidays hol-loaddefs
cal-menu easymenu calendar cal-loaddefs time time-date tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind dynamic-setting system-font-setting font-render-setting
move-toolbar gtk x-toolkit x multi-tty emacs)

==John ffitch