bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#13054: Assume POSIX 1003.1-1988 or later for execve.


From: Eli Zaretskii
Subject: bug#13054: Assume POSIX 1003.1-1988 or later for execve.
Date: Sun, 02 Dec 2012 19:03:39 +0200

> Date: Sat, 01 Dec 2012 22:37:39 -0600
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
> 
> Attached is a patch to simplify Emacs that I discovered while looking
> into the putenv/setenv problem.  It affects the NT port so I'm
> CC'ing this to Eli to give him a heads-up.

Thanks.  You can go ahead and commit this, these changes don't affect
MS-Windows at all (except in trivial "a = b; b = a;" way, without
changing a or b in between).

However, please omit these changes from the changeset:

> === modified file 'lib-src/ntlib.h'
> --- lib-src/ntlib.h   2012-01-19 07:21:25 +0000
> +++ lib-src/ntlib.h   2012-12-02 04:32:26 +0000
> @@ -79,6 +79,7 @@
>  
>  /* map to MSVC names */
>  #define execlp    _execlp
> +#define execve    _execve
>  #define execvp    _execvp
>  #define fdopen         _fdopen
>  #ifndef fileno
> @@ -104,4 +105,3 @@
>  #undef _WINSOCK_H
>  
>  /* end of ntlib.h */
> -
> 
> === modified file 'nt/ChangeLog'
> --- nt/ChangeLog      2012-12-01 20:09:30 +0000
> +++ nt/ChangeLog      2012-12-02 04:32:26 +0000
> @@ -1,3 +1,8 @@
> +2012-12-02  Paul Eggert  <eggert@cs.ucla.edu>
> +
> +     Assume POSIX 1003.1-1988 or later for execve.
> +     * inc/ms-w32.h (execve): New macro.
> +
>  2012-12-01  Juanma Barranquero  <lekktu@gmail.com>
>  
>       * config.nt: Sync with autogen/config.in.
> 
> === modified file 'nt/inc/ms-w32.h'
> --- nt/inc/ms-w32.h   2012-11-27 03:10:32 +0000
> +++ nt/inc/ms-w32.h   2012-12-02 04:32:26 +0000
> @@ -204,6 +204,7 @@
>  
>  /* Map to MSVC names.  */
>  #define execlp    _execlp
> +#define execve    _execve
>  #define execvp    _execvp
>  #define fdopen         _fdopen
>  #ifndef fileno
> 

They are not needed.  (The Windows build of Emacs doesn't use any
functions of the exec* family, because they are fundamentally broken
on Windows.  I will look into removing the other exec* macros from
Windows-specific files.)





reply via email to

[Prev in Thread] Current Thread [Next in Thread]