[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#13164: [PATCH] View DjVu documents through doc-view-mode
From: |
Stefan Monnier |
Subject: |
bug#13164: [PATCH] View DjVu documents through doc-view-mode |
Date: |
Wed, 23 Jan 2013 08:18:37 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
>>> Could someone bisect to find the commit that introduced this problem?
>> Yes, I can do that. I'll report back when I'm done.
> Ok, I'm done.
Thank you very much.
> --8<---------------cut here---------------start------------->8---
> 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d is the first bad commit
> commit 046fb9fbdc0ee0c26e0063ce5ee94bead46ee98d
> Author: Dmitry Antipov <dmantipov@yandex.ru>
> Date: Tue Dec 11 13:51:12 2012 +0400
> * buffer.c (Fset_buffer_multibyte): Do not force redisplay
> if changed buffer is not shown in a window.
> * insdel.c (prepare_to_modify_buffer): Likewise.
> * window.c (replace_buffer_in_windows_safely): Do nothing
> if buffer is not shown in a window.
> (Fforce_window_update): Likewise if string or buffer argument
> is passed.
Dmitry, could you take a look at this? It looks like the new code's
more aggressive avoidance of redisplay ends up leaving some mode-lines
out-of-date after running timers.
I don't see any immediate connection between the above commit message
and doc-view's timer behavior, so maybe the problem is a problem in
your commit.
OTOH maybe doc-view was simply lucky that the redisplay was not
optimized enough and we should really use something like the patch below,
> Are there any instructions on doing bisection on emacs bzr?
My impression that "bzr bisect" is in the same boat as "bzr switch" and
"bzr rebase": kinda works sometimes, but not nearly robust enough.
Stefan
=== modified file 'lisp/doc-view.el'
--- lisp/doc-view.el 2013-01-10 15:50:04 +0000
+++ lisp/doc-view.el 2013-01-23 13:14:23 +0000
@@ -1265,6 +1265,8 @@
"[0-9]+")
t)
'doc-view-sort))
+ (unless (eq (length prev-pages) (length doc-view-current-files))
+ (force-mode-line-update))
(dolist (win (or (get-buffer-window-list buffer nil t)
(list t)))
(let* ((page (doc-view-current-page win))
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Stefan Monnier, 2013/01/09
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Elias Pipping, 2013/01/09
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Stefan Monnier, 2013/01/10
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Tassilo Horn, 2013/01/11
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Elias Pipping, 2013/01/21
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Stefan Monnier, 2013/01/22
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Tassilo Horn, 2013/01/22
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Tassilo Horn, 2013/01/23
- bug#13164: [PATCH] View DjVu documents through doc-view-mode,
Stefan Monnier <=
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Dmitry Antipov, 2013/01/23
- bug#13164: [PATCH] View DjVu documents through doc-view-mode, Tassilo Horn, 2013/01/24