|
From: | Stefan Monnier |
Subject: | bug#6799: 24.0.50; Please add dired-details.el to Emacs [patch] |
Date: | Sun, 10 Feb 2013 22:37:53 -0500 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> Here is the final patch. Drew Adams and Michael Heerdegen tested it and > did not find any problems. Thanks. A few nitpicks and comments below. > + ;; ignore dired-hide-details-* value of invisible text property by default > + (when (eq buffer-invisibility-spec t) > + (setq buffer-invisibility-spec (list t))) Please capitalize and punctuate your comments. > (forward-line arg) > + (while (and (progn > + (while (and (< arg 0) > + (bolp) > + (/= (1+ (point)) (point-max)) > + (eq (get-text-property (1+ (point)) 'invisible) > + 'dired-hide-details-information)) > + (forward-char -1)) > + (invisible-p (point))) > + (let ((p (funcall (if (> arg 0) > + 'next-single-property-change > + 'previous-single-property-change) > + (point) > + 'invisible))) > + (when p > + (goto-char p) > + t)))) > (dired-move-to-filename)) What is this for? > + (if (derived-mode-p 'locate-mode) > + (setq dired-hide-details-mode nil) Could you explain why locate-mode needs such special treatment (here and in locate-mode-map)? I'm mostly worried here that maybe some other mode might require similar treatment. Stefan
[Prev in Thread] | Current Thread | [Next in Thread] |