[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value
|
From: |
Stefan Monnier |
|
Subject: |
bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT |
|
Date: |
Thu, 11 Apr 2013 10:03:49 -0400 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> Isn't there a bad usage of `completing-read' here, IMO the
> DEFAULT arg of `completing-read' should be used instead of:
> ,----
> | (if (string-equal "" str) default str)
> `----
Sounds like a left-over from previous code, indeed.
> Also why is 'default' let-bounded ?
> Here a patch:
Feel free to install it (assuming you've confirmed it works, that is ;-)
Stefan
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Drew Adams, 2013/04/10
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Thierry Volpiatto, 2013/04/11
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT,
Stefan Monnier <=
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Drew Adams, 2013/04/11
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Thierry Volpiatto, 2013/04/12
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Drew Adams, 2013/04/12
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Thierry Volpiatto, 2013/04/13
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Drew Adams, 2013/04/13
- bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT, Stefan Monnier, 2013/04/19