[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14233: 24.3; Don't constrain frame size to character multiples
From: |
Jan Djärv |
Subject: |
bug#14233: 24.3; Don't constrain frame size to character multiples |
Date: |
Mon, 22 Apr 2013 18:11:12 +0200 |
Hello.
22 apr 2013 kl. 17:36 skrev martin rudalics <rudalics@gmx.at>:
> >> The interface to the window subsystem will be the function
> >>
> >> change_frame_size (struct frame *f, int new_width, int new_height,
> >> bool pretend, bool delay, bool safe, bool pixelwise)
> >>
> >> which processes new_width and new_height in terms of pixels if pixelwise
> >> is non-nil.
>
> I meant 1 here.
>
> > This is insane. it means changing lots and lots of calls, and makes merging
> > between branches harder.
>
> Currently, change_frame_size doesn't know anything about the various
> platforms' requirements going beyond those of the frame's text area.
I don't understand what you are trying to say.
> > Make a new function (change_frame_size_pixelwise for example), with the
> > arguments above, and let change_frame_size call it with the last argument
> > false.
>
> And how would change_frame_size know what the new pixel dimensions of
> the frame's text area are?
As Emacs has always done, multiply by canonical character pixel size.
The point is that for X and NS there are probably just a few places where pixel
size is needed. Better to have a new name anyway so that we see it is a
different function. This helps in backports, for example.
Jan D.
- bug#14233: 24.3; Don't constrain frame size to character multiples, (continued)
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, Stefan Monnier, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/21
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/21
- bug#14233: 24.3; Don't constrain frame size to character multiples, E Sabof, 2013/04/20
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/21
- bug#14233: 24.3; Don't constrain frame size to character multiples, Jan Djärv, 2013/04/21
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, Jan Djärv, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples,
Jan Djärv <=
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, Eli Zaretskii, 2013/04/22
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/23
- bug#14233: 24.3; Don't constrain frame size to character multiples, Eli Zaretskii, 2013/04/23
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/24
- bug#14233: 24.3; Don't constrain frame size to character multiples, Eli Zaretskii, 2013/04/24
- bug#14233: 24.3; Don't constrain frame size to character multiples, Jan Djärv, 2013/04/23
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/23
- bug#14233: 24.3; Don't constrain frame size to character multiples, Eli Zaretskii, 2013/04/23
- bug#14233: 24.3; Don't constrain frame size to character multiples, martin rudalics, 2013/04/24